addressed review comments#463
Merged
tanmaya-panda1 merged 3 commits intofeature/IngestV2from Feb 18, 2026
Merged
Conversation
tanmaya-panda1
had a problem deploying
to
build
GitHub Actions
Failure
AsafMah
reviewed
Feb 15, 2026
Contributor
AsafMah
left a comment
AsafMah
left a comment
There was a problem hiding this comment.
The round robin builder looks good, but keep in mind the consistency of the code.
...t-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/builders/BaseIngestClientBuilder.kt
Outdated
Show resolved
Hide resolved
ingest-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/client/QueuedIngestClient.kt
Show resolved
Hide resolved
...2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/client/ManagedStreamingIngestClient.kt
Show resolved
Hide resolved
tanmaya-panda1
had a problem deploying
to
build
GitHub Actions
Failure
Collaborator
Author
simplified the container selection logic and added tests in the recent commit |
AsafMah
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new utility object for consistent endpoint handling and improves Java interoperability in the Kusto ingest client library. The main changes are the centralization of ingestion/query endpoint logic, simplification of builder classes, and the addition of Java-friendly asynchronous APIs.
Endpoint handling improvements:
IngestClientBaseKotlin object that centralizes logic for converting between cluster, ingestion, and query endpoint URLs, with special handling for reserved hostnames and local development scenarios. (ingest-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/IngestClientBase.kt)BaseIngestClientBuilder,QueuedIngestClientBuilder,StreamingIngestClientBuilder) to use the newIngestClientBasefor endpoint normalization, removing redundant endpoint properties and logic. (ingest-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/builders/BaseIngestClientBuilder.kt,QueuedIngestClientBuilder.kt,StreamingIngestClientBuilder.kt) [1] [2] [3] [4] [5] [6] [7] [8]Java interoperability enhancements:
CompletableFuture) to theIngestClientandMultiIngestClientinterfaces, providing better support for Java consumers and avoiding JVM signature conflicts with suspend functions. (ingest-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/client/IngestClient.kt) [1] [2] [3]ManagedStreamingIngestClientandQueuedIngestClient, replacing previous@JvmNameworkarounds with proper interface overrides. (ManagedStreamingIngestClient.kt,QueuedIngestClient.kt) [1] [2] [3] [4] [5] [6]These changes improve maintainability, ensure endpoint logic is consistent across the codebase, and provide a more robust API for both Kotlin and Java consumers.This pull request introduces a new utility object for consistent endpoint handling and improves Java interoperability in the Kusto ingest client library. The main changes are the centralization of ingestion/query endpoint logic, simplification of builder classes, and the addition of Java-friendly asynchronous APIs.
Endpoint handling improvements:
IngestClientBaseKotlin object that centralizes logic for converting between cluster, ingestion, and query endpoint URLs, with special handling for reserved hostnames and local development scenarios. (ingest-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/IngestClientBase.kt)BaseIngestClientBuilder,QueuedIngestClientBuilder,StreamingIngestClientBuilder) to use the newIngestClientBasefor endpoint normalization, removing redundant endpoint properties and logic. (ingest-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/builders/BaseIngestClientBuilder.kt,QueuedIngestClientBuilder.kt,StreamingIngestClientBuilder.kt) [1] [2] [3] [4] [5] [6] [7] [8]Java interoperability enhancements:
CompletableFuture) to theIngestClientandMultiIngestClientinterfaces, providing better support for Java consumers and avoiding JVM signature conflicts with suspend functions. (ingest-v2/src/main/kotlin/com/microsoft/azure/kusto/ingest/v2/client/IngestClient.kt) [1] [2] [3]ManagedStreamingIngestClientandQueuedIngestClient, replacing previous@JvmNameworkarounds with proper interface overrides. (ManagedStreamingIngestClient.kt,QueuedIngestClient.kt) [1] [2] [3] [4] [5] [6]These changes improve maintainability, ensure endpoint logic is consistent across the codebase, and provide a more robust API for both Kotlin and Java consumers.### Added
Changed
Fixed