Skip to content

Catch exception if host is not available #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2020
Merged

Catch exception if host is not available #174

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8aa7520
Catch exception if host is not available
dingmeng-xue Mar 2, 2020
2cb76a2
Merge remote-tracking branch 'upstream/master' into telemetry
dingmeng-xue Mar 2, 2020
5ae2a88
remove and sort usings
dingmeng-xue Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 34 additions & 19 deletions src/Common/AzurePSCmdlet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,32 +870,47 @@ public virtual bool IsTerminatingError(Exception ex)

protected string LoadAzVersion()
{
Version latestAz = new Version("0.0.0");
Version defautVersion = new Version("0.0.0");
if (this.Host == null)
{
WriteDebug("Cannot fetch Az version due to no host in current environment");
return defautVersion.ToString();
}

Version latestAz = defautVersion;
string latestSuffix = "";
using (var powershell = System.Management.Automation.PowerShell.Create())
{
powershell.Runspace = RunspaceFactory.CreateRunspace(this.Host);
powershell.AddCommand("Get-Module");
powershell.AddParameter("Name", "Az");
powershell.AddParameter("ListAvailable", true);
powershell.Runspace.Open();
Collection<PSObject> outputs = powershell.Invoke();
foreach (PSObject obj in outputs)
try
{
string psVersion = obj.Properties["Version"].Value.ToString();
int pos = psVersion.IndexOf('-');
string currentSuffix = (pos == -1 || pos == psVersion.Length - 1) ? "" : psVersion.Substring(pos + 1);
Version currentAz = (pos == -1) ? new Version(psVersion) : new Version(psVersion.Substring(0, pos));
if (currentAz > latestAz)
{
latestAz = currentAz;
latestSuffix = currentSuffix;
}
else if (currentAz == latestAz)
powershell.Runspace = RunspaceFactory.CreateRunspace(this.Host);
powershell.AddCommand("Get-Module");
powershell.AddParameter("Name", "Az");
powershell.AddParameter("ListAvailable", true);
powershell.Runspace.Open();
Collection<PSObject> outputs = powershell.Invoke();
foreach (PSObject obj in outputs)
{
latestSuffix = String.Compare(latestSuffix, currentSuffix) > 0 ? latestSuffix : currentSuffix;
string psVersion = obj.Properties["Version"].Value.ToString();
int pos = psVersion.IndexOf('-');
string currentSuffix = (pos == -1 || pos == psVersion.Length - 1) ? "" : psVersion.Substring(pos + 1);
Version currentAz = (pos == -1) ? new Version(psVersion) : new Version(psVersion.Substring(0, pos));
if (currentAz > latestAz)
{
latestAz = currentAz;
latestSuffix = currentSuffix;
}
else if (currentAz == latestAz)
{
latestSuffix = String.Compare(latestSuffix, currentSuffix) > 0 ? latestSuffix : currentSuffix;
}
}
}
catch (Exception e)
{
WriteDebug(string.Format("Cannot fetch Az version due to exception: {0}", e.Message));
return defautVersion.ToString();
}
}
string ret = latestAz.ToString();
if (!String.IsNullOrEmpty(latestSuffix))
Expand Down