Net452 targets file #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Using shared snk file. Added packages.config.lnk for net42.
…seems that you cannot mix Reference and PackageReference in the same file, even if they are not loaded via a condition. It causes issues for NuGet package manager, and it won't load any packages properly.
Contributor
Author
|
Note: I'd like to clean up a bit more and pull the latest from develop prior to merging this. |
Contributor
Author
|
I've done the cleanup now. Should be good to go. |
# Conflicts: # src/Storage.Management/Storage.Management.csproj
…powershell-common into net452-targets-file
cormacpayne
previously approved these changes
Aug 30, 2018
Member
cormacpayne
left a comment
cormacpayne
left a comment
There was a problem hiding this comment.
LGTM as long as we've validated signed packages with these changes being consumed in PowerShell
Contributor
Author
|
@cormacpayne Will do that now. |
…edRules.ruleset warning.
…powershell-common into net452-targets-file
Contributor
Author
cormacpayne
approved these changes
Aug 31, 2018
This was referenced Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a net452 targets file. It is separated into Framework and then the dependencies are separated by usage. Some are used by RM, SM, Test, or a mix of any of those. Unfortunately, you cannot mix Reference and PackageReference together, so I cannot have a single Framework targets file for both net452 and netstandard20. I also did various cleaning. Removed all packages.config except for the one that drives the process, and added a shortcut to it in src. Removed duplicate snk files and all projects simply copy the same snk file. Build process is even faster now because of an extremely consolidated set of packages for net452.