Skip to content

Conversation

@blueww
Copy link
Member

@blueww blueww commented Nov 26, 2019

Description

And upgrade API version to 2019-06-01
Update Unit test accordingly. (Server has some behavior change, so change test case to align with it.)

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly
Copy link
Collaborator

Hi @blueww ,

there are test cases failed and breaking change issue in CI, can you take a look?

@blueww
Copy link
Member Author

blueww commented Nov 28, 2019

@VeryEarly
Thanks for the remind!
I have raised a fix for it.
Let's see if it can pass build with the fix.

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Pull request contains merge conflicts.

@VeryEarly
Copy link
Collaborator

@VeryEarly
Thanks for the remind!
I have raised a fix for it.
Let's see if it can pass build with the fix.

Hi @blueww

there are conflicts in your pr, can you try fix them?

@blueww
Copy link
Member Author

blueww commented Nov 29, 2019

@VeryEarly
I have updated the PR:

  1. rebase the code change to fix the conflict
  2. Add a new type PSSku to replace the Sku Type from SDK, since the Sku type from SDK removed some properties (these properties should not be add, since server won't return them).
  3. Add some breaking change exception since sku type change. Anyway, this is not real breaking. As I confirmed with Mark before, when the type change, but the content of the type not change, it's not breaking. See [Storage] Upgrade to XSCL 10 (depends on PR #9037, to upgrade SRP SDK) #9005

@VeryEarly VeryEarly self-requested a review November 29, 2019 04:04
@blueww
Copy link
Member Author

blueww commented Nov 29, 2019

@VeryEarly
Thanks for the review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants