-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Storage] Upgrade to XSCL 10 (depends on PR #9037, to upgrade SRP SDK) #9005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ca9c683 to
5692904
Compare
|
Currently we use private (not signed) DMlib. Will upgrade to signed one when DMlib release. Would you please first help to review the PR,but don't merge until I upgrade to signed DMlib? |
|
Would you please help to review this? We target this PR for Build release.
|
|
Waiing on #9037 |
|
I have fixed the merge conflict, but the build failed on powershell-core still fail for same issue, would you please help to look?
|
|
@markcowl |
|
@markcowl |
Description
This PR is mainly to upgrade to Azure Storage Client library(aka: XSCL) 10.0.1.
It also include the code change of PR #9037
(Since we need to upgrade both SDK in Build release, and they have some code change need merge)
For XSCL 10.0.1:
The namespace of XSCL changed from
Microsoft.WindowsAzure.Storage.*toMicrosoft.Azure.Storage.*, so:For SRP SDK 11.0:
The storage account Kind in SRP SDK is change from a enum to string, but the value is same.
So the PSStorageAccount.Kind also change type to string, but the value is same, so it won't block customer script.
There're 2 breaking changes :
change output type of
New/Get/Set-AzStorageAccount: ThePSStorageAccount.Sku.Namevalue is changed ('-' added). The Change is expected, since in New/Set-AzStorageAccount cmdlet, the input SkuName has '-' (before, the output don't have '-'), so with the change the input and output Sku Name value will be aligned."StandardLRS" -> "Standard_LRS";
"StandardGRS" -> "Standard_GRS";
"StandardRAGRS" -> "Standard_RAGRS";
"StandardZRS" -> "Standard_ZRS";
"PremiumLRS" -> "Premium_LRS";
"PremiumZRS" -> "Premium_ZRS";
The default Storage Account Kind in
New-AzStorageAccountis changed to StorageV2. Since per SRP team, this should be the default Storage Kind.Checklist
CONTRIBUTING.mdplatyPSmodule