Skip to content

Conversation

@blueww
Copy link
Member

@blueww blueww commented Apr 15, 2019

Description

This PR is mainly to upgrade to Azure Storage Client library(aka: XSCL) 10.0.1.
It also include the code change of PR #9037
(Since we need to upgrade both SDK in Build release, and they have some code change need merge)

For XSCL 10.0.1:

The namespace of XSCL changed from Microsoft.WindowsAzure.Storage.* to Microsoft.Azure.Storage.*, so:

  1. Added many breaking change exception, since the output/input type namespace change . (Confirmed with Mark, this is not real breaking, as long as the content of the type not change)
  2. Move some file original in shared XSCL swapper to storage folder, since the namespace change of XSCL
  3. Modify some test cases to add support to -asjob, and queue namespace change.

For SRP SDK 11.0:

The storage account Kind in SRP SDK is change from a enum to string, but the value is same.
So the PSStorageAccount.Kind also change type to string, but the value is same, so it won't block customer script.

There're 2 breaking changes :

  1. change output type of New/Get/Set-AzStorageAccount : The PSStorageAccount.Sku.Name value is changed ('-' added). The Change is expected, since in New/Set-AzStorageAccount cmdlet, the input SkuName has '-' (before, the output don't have '-'), so with the change the input and output Sku Name value will be aligned.
    "StandardLRS" -> "Standard_LRS";
    "StandardGRS" -> "Standard_GRS";
    "StandardRAGRS" -> "Standard_RAGRS";
    "StandardZRS" -> "Standard_ZRS";
    "PremiumLRS" -> "Premium_LRS";
    "PremiumZRS" -> "Premium_ZRS";

  2. The default Storage Account Kind in New-AzStorageAccount is changed to StorageV2. Since per SRP team, this should be the default Storage Kind.

Checklist

@blueww blueww requested a review from markcowl April 15, 2019 02:35
@blueww blueww force-pushed the xscl10 branch 3 times, most recently from ca9c683 to 5692904 Compare April 15, 2019 04:01
@blueww blueww requested a review from maddieclayton April 15, 2019 07:53
@blueww
Copy link
Member Author

blueww commented Apr 15, 2019

Currently we use private (not signed) DMlib. Will upgrade to signed one when DMlib release.
There are some test cases failed since DMlib not signed.

Would you please first help to review the PR,but don't merge until I upgrade to signed DMlib?

@blueww
Copy link
Member Author

blueww commented Apr 19, 2019

@markcowl

Would you please help to review this? We target this PR for Build release.
This only build failure is caused by the test machine issue:
Error message is:

The command "sudo apt-get install -qq dotnet-sdk-2.1=2.1.400*" failed and exited with 100 during

@blueww blueww changed the title [Storage] Upgrade to XSCL 10 [Storage] Upgrade to XSCL 10 (depends on PR #9037, to upgrade SRP SDK) Apr 22, 2019
@blueww blueww mentioned this pull request Apr 22, 2019
7 tasks
@markcowl
Copy link
Member

Waiing on #9037

@blueww
Copy link
Member Author

blueww commented Apr 22, 2019

@markcowl

I have fixed the merge conflict, but the build failed on powershell-core still fail for same issue, would you please help to look?

/.azure-pipelines/powershell-core.yml: Could not find /.azure-pipelines/util/analyze-steps.yml in repository self hosted on https://api.github.com using commit 3f9776c. GitHub reported the error, "Not Found"

@blueww
Copy link
Member Author

blueww commented Apr 23, 2019

@markcowl
I have resolved the merge conflict. Please help to review.

@blueww
Copy link
Member Author

blueww commented Apr 23, 2019

@markcowl
The build check pass for this PR, and the conflict is resolved.
Would you please help to review and merge this PR if no other issue?
Thanks!

@markcowl markcowl merged commit 6493f3a into Azure:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants