DeploymentManager module update for new API version #10739

deveshguha · 2019-12-18T02:56:48Z

Description

This enhances the DeploymentMananger module for the new preview API version we recently published.

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
- the markdown help files have been regenerated using the commands listed here

src/DeploymentManager/DeploymentManager/Az.DeploymentManager.psd1

src/DeploymentManager/DeploymentManager/Commands/GetArtifactSource.cs

deveshguha · 2019-12-19T00:04:03Z

@msJinLei Updated help files as well as part of incorporating your feedback. Also, fixed parameter sets for New/Get commands of two child resources that was missed last time.

src/DeploymentManager/DeploymentManager/Commands/GetServiceTopology.cs

src/DeploymentManager/DeploymentManager/Commands/GetStep.cs

src/DeploymentManager/DeploymentManager/Commands/NewStep.cs

src/DeploymentManager/DeploymentManager/Commands/GetService.cs

msJinLei · 2019-12-26T04:23:04Z

Please add back ValidateNotNullOrEmpty if it is needed & sorry for misunderstanding
adding new mandatory parameter & changing position attributes are all breaking changes. You should
- put breaking changes notification in the master
- release your break changes in the next breaking changes release (May, 2020)
- Refer to https://github.com/Azure/azure-powershell/tree/master/documentation/breaking-changes

This reverts commit eb119c4.

deveshguha · 2019-12-27T06:02:26Z

Please add back ValidateNotNullOrEmpty if it is needed & sorry for misunderstanding

adding new mandatory parameter & changing position attributes are all breaking changes. You should

put breaking changes notification in the master

release your break changes in the next breaking changes release (May, 2020)

Refer to https://github.com/Azure/azure-powershell/tree/master/documentation/breaking-changes

Reverted all breaking and related changes. Regenerated help files.

deveshguha · 2020-01-03T00:56:55Z

@msJinLei Let me know if there is anything else required for merging this.

msJinLei · 2020-01-08T02:19:07Z

@msJinLei Let me know if there is anything else required for merging this.

Refer to the error message of the failed test case.

[xUnit.net 00:00:06.79]     Microsoft.Azure.Commands.DeploymentManager.Test.ScenarioTests.DeploymentManagerTests.EndToEndFunctionalTests [FAIL]
2020-01-06T20:40:03.1792637Z     X Microsoft.Azure.Commands.DeploymentManager.Test.ScenarioTests.DeploymentManagerTests.EndToEndFunctionalTests [4s 672ms]
2020-01-06T20:40:03.1892732Z EXEC : error Message:  [/home/vsts/work/1/s/build.proj]
2020-01-06T20:40:03.1903219Z      System.Management.Automation.ActionPreferenceStopException : The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: The health check properties file path 'ScenarioTests\RestHealthCheckProperties.json' does not exist.
2020-01-06T20:40:03.1909755Z     Stack Trace:
2020-01-06T20:40:04.0591575Z        at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
2020-01-06T20:40:04.0939899Z      at System.Management.Automation.Runspaces.Pipeline.Invoke()
2020-01-06T20:40:04.0940763Z      at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)
2020-01-06T20:40:04.0941092Z      at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync)
2020-01-06T20:40:04.0941365Z      at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
2020-01-06T20:40:04.0941646Z      at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
2020-01-06T20:40:04.0941916Z      at System.Management.Automation.PowerShell.CoreInvoke[TOutput](IEnumerable input, PSDataCollection`1 output, PSInvocationSettings settings)
2020-01-06T20:40:04.0942141Z      at System.Management.Automation.PowerShell.Invoke(IEnumerable input, PSInvocationSettings settings)
2020-01-06T20:40:04.0942389Z      at System.Management.Automation.PowerShell.Invoke()
2020-01-06T20:40:04.0942622Z      at Microsoft.WindowsAzure.Commands.ScenarioTest.EnvironmentSetupHelper.RunPowerShellTest(String[] scripts) in /home/vsts/work/1/s/tools/ScenarioTest.ResourceManager/EnvironmentSetupHelper.cs:line 571
2020-01-06T20:40:04.0942948Z      at Microsoft.Azure.Commands.DeploymentManager.Test.ScenarioTests.DeploymentManagerController.RunPowerShellTest(XunitTracingInterceptor logger, String[] scripts) in /home/vsts/work/1/s/src/DeploymentManager/DeploymentManager.Test/ScenarioTests/DeploymentManagerController.cs:line 112
2020-01-06T20:40:04.0943349Z      at Microsoft.Azure.Commands.DeploymentManager.Test.ScenarioTests.DeploymentManagerTests.EndToEndFunctionalTests() in /home/vsts/work/1/s/src/DeploymentManager/DeploymentManager.Test/ScenarioTests/DeploymentManagerTests.cs:line 37
2020-01-06T20:40:04.0943616Z     Standard Output Messages:
2020-01-06T20:40:04.1851357Z    Test-EndToEndFunctionalTests
2020-01-06T20:40:04.1854059Z    Caught Exception: System.Management.Automation.ActionPreferenceStopException: The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: The health check properties file path 'ScenarioTests\RestHealthCheckProperties.json' does not exist.
2020-01-06T20:40:04.1854485Z       at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
2020-01-06T20:40:04.1854768Z       at System.Management.Automation.Runspaces.Pipeline.Invoke()
2020-01-06T20:40:04.1854991Z       at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)
2020-01-06T20:40:04.1855231Z       at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync)
2020-01-06T20:40:04.1855475Z       at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
2020-01-06T20:40:04.1855981Z       at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
2020-01-06T20:40:04.1856241Z       at System.Management.Automation.PowerShell.CoreInvoke[TOutput](IEnumerable input, PSDataCollection`1 output, PSInvocationSettings settings)
2020-01-06T20:40:04.1856465Z       at System.Management.Automation.PowerShell.Invoke(IEnumerable input, PSInvocationSettings settings)
2020-01-06T20:40:04.1856856Z       at System.Management.Automation.PowerShell.Invoke()
2020-01-06T20:40:04.1857086Z       at Microsoft.WindowsAzure.Commands.ScenarioTest.EnvironmentSetupHelper.RunPowerShellTest(String[] scripts) in /home/vsts/work/1/s/tools/ScenarioTest.ResourceManager/EnvironmentSetupHelper.cs:line 571
2020-01-06T20:40:04.1857798Z    Message: The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: The health check properties file path 'ScenarioTests\RestHealthCheckProperties.json' does not exist.
2020-01-06T20:40:04.1950158Z EXEC : PowerShell error Record: The health check properties file path 'ScenarioTests\RestHealthCheckProperties.json' does not exist. [/home/vsts/work/1/s/build.proj]
2020-01-06T20:40:04.1951241Z    Exception:System.IO.FileNotFoundException: The health check properties file path 'ScenarioTests\RestHealthCheckProperties.json' does not exist.
2020-01-06T20:40:04.1951845Z       at Microsoft.Azure.Commands.DeploymentManager.Utilities.FileUtilities.GetHealthCheckPropertiesFromFile(String currentPath, String propertiesFilePath) in /home/vsts/work/1/s/src/DeploymentManager/DeploymentManager/Utilities/FileUtilities.cs:line 33
2020-01-06T20:40:04.1952353Z       at Microsoft.Azure.Commands.DeploymentManager.Commands.NewStep.GetProperties() in /home/vsts/work/1/s/src/DeploymentManager/DeploymentManager/Commands/NewStep.cs:line 129
2020-01-06T20:40:04.1952772Z       at Microsoft.Azure.Commands.DeploymentManager.Commands.NewStep.ExecuteCmdlet() in /home/vsts/work/1/s/src/DeploymentManager/DeploymentManager/Commands/NewStep.cs:line 96
2020-01-06T20:40:04.1953172Z       at Microsoft.WindowsAzure.Commands.Utilities.Common.AzurePSCmdlet.ProcessRecord()
2020-01-06T20:40:04.1953525Z    Details:
2020-01-06T20:40:04.1954302Z    Script Stack Trace: at Test-HealthCheckStep, /home/vsts/work/1/s/src/DeploymentManager/DeploymentManager.Test/bin/Debug/netcoreapp2.2/ScenarioTests/DeploymentManagerTests.ps1: line 414
2020-01-06T20:40:04.1955170Z    at Test-Steps, /home/vsts/work/1/s/src/DeploymentManager/DeploymentManager.Test/bin/Debug/netcoreapp2.2/ScenarioTests/DeploymentManagerTests.ps1: line 368
2020-01-06T20:40:04.1956045Z    at Test-ServiceUnit, /home/vsts/work/1/s/src/DeploymentManager/DeploymentManager.Test/bin/Debug/netcoreapp2.2/ScenarioTests/DeploymentManagerTests.ps1: line 273
2020-01-06T20:40:04.1956873Z    at Test-Service, /home/vsts/work/1/s/src/DeploymentManager/DeploymentManager.Test/bin/Debug/netcoreapp2.2/ScenarioTests/DeploymentManagerTests.ps1: line 166
2020-01-06T20:40:04.1957741Z    at Test-ServiceTopology, /home/vsts/work/1/s/src/DeploymentManager/DeploymentManager.Test/bin/Debug/netcoreapp2.2/ScenarioTests/DeploymentManagerTests.ps1: line 92
2020-01-06T20:40:04.1958596Z    at Test-EndToEndFunctionalTests, /home/vsts/work/1/s/src/DeploymentManager/DeploymentManager.Test/bin/Debug/netcoreapp2.2/ScenarioTests/DeploymentManagerTests.ps1: line 47
2020-01-06T20:40:04.1959070Z    at <ScriptBlock>, <No file>: line 1

you can find the error log by clicking "Detail"

msJinLei · 2020-01-08T02:25:05Z

/azp run

azure-pipelines · 2020-01-08T02:25:24Z

Azure Pipelines successfully started running 3 pipeline(s).

msJinLei · 2020-01-08T08:41:39Z

@deveshguha
Please fix the credential scan error

              "EndToEndFunctionalTests.json",
              "ConfigFile",
              "Found password, symmetric key or storage credential in source file.",
              "Validate file contains secrets, remove, roll credential, and use approved store. For additional information on secret remediation see https://aka.ms/credscan "

src/DeploymentManager/DeploymentManager.Test/ScenarioTests/DeploymentManagerTests.ps1

deveshguha · 2020-01-08T18:11:05Z

@deveshguha
Please fix the credential scan error

              "EndToEndFunctionalTests.json",
              "ConfigFile",
              "Found password, symmetric key or storage credential in source file.",
              "Validate file contains secrets, remove, roll credential, and use approved store. For additional information on secret remediation see https://aka.ms/credscan "

It is an expired test session storage SAS URI. Added exception.

msJinLei · 2020-01-10T02:15:45Z

@deveshguha Please remove the references to "Microsoft.Azure.Management.DeploymentManager.*-preview.nupkg" in LocalFeed. The package can be retrieved by nuget.

DeploymentManager module update for new API version

deveshguha added 2 commits December 17, 2019 14:43

ADM Preview 2019-11-01

4258fc1

Update metadata and help

c8bc6d1

azuresdkci added the needs-review label Dec 18, 2019

msJinLei assigned bryevdv and deveshguha Dec 18, 2019

msJinLei added needs-revision and removed needs-review labels Dec 18, 2019

msJinLei assigned msJinLei and unassigned bryevdv Dec 18, 2019

msJinLei suggested changes Dec 18, 2019

View reviewed changes

src/DeploymentManager/DeploymentManager/Az.DeploymentManager.psd1 Show resolved Hide resolved

src/DeploymentManager/DeploymentManager/Commands/GetArtifactSource.cs Show resolved Hide resolved

Fix Parameter sets; Update help files

eb119c4

msJinLei reviewed Dec 26, 2019

View reviewed changes

src/DeploymentManager/DeploymentManager/Commands/GetServiceTopology.cs Show resolved Hide resolved

msJinLei reviewed Dec 26, 2019

View reviewed changes

src/DeploymentManager/DeploymentManager/Commands/GetStep.cs Show resolved Hide resolved

msJinLei suggested changes Dec 26, 2019

View reviewed changes

src/DeploymentManager/DeploymentManager/Commands/NewStep.cs Show resolved Hide resolved

src/DeploymentManager/DeploymentManager/Commands/GetService.cs Outdated Show resolved Hide resolved

deveshguha added 3 commits December 26, 2019 09:51

Incorporate feedback

d039efd

Revert "Fix Parameter sets; Update help files"

e70bcae

This reverts commit eb119c4.

Revert ParamSets; Regenerate help files

62cb6aa

Enhanced tests

026064c

Fix error message format

be7480d

Modify test file path

3271df8

msJinLei reviewed Jan 8, 2020

View reviewed changes

src/DeploymentManager/DeploymentManager.Test/ScenarioTests/DeploymentManagerTests.ps1 Outdated Show resolved Hide resolved

Incorporate feedback; fix credscan

c7c045f

Remove local packages

ac639fe

msJinLei added Waiting for CI and removed needs-revision labels Jan 10, 2020

msJinLei unassigned deveshguha Jan 10, 2020

msJinLei approved these changes Jan 10, 2020

View reviewed changes

msJinLei merged commit d0e54f6 into Azure:master Jan 10, 2020

dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020

Merge pull request Azure#10739 from deveshguha/adm-preview-2019-11

48cd733

DeploymentManager module update for new API version

DeploymentManager module update for new API version #10739

DeploymentManager module update for new API version #10739

Uh oh!

Conversation

deveshguha commented Dec 18, 2019

Description

Checklist

Uh oh!

Uh oh!

Uh oh!

deveshguha commented Dec 19, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msJinLei commented Dec 26, 2019

Uh oh!

deveshguha commented Dec 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deveshguha commented Jan 3, 2020

Uh oh!

msJinLei commented Jan 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msJinLei commented Jan 8, 2020

Uh oh!

azure-pipelines bot commented Jan 8, 2020

Uh oh!

msJinLei commented Jan 8, 2020

Uh oh!

Uh oh!

deveshguha commented Jan 8, 2020

Uh oh!

msJinLei commented Jan 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

deveshguha commented Dec 27, 2019 •

edited

Loading

msJinLei commented Jan 8, 2020 •

edited

Loading