-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Compute] ColocationStatus for PPG. #10795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@msJinLei Hi, there is no breaking change in this PR. The line you mentioned is just a help file update. The existing help file is incorrect. Also, the change of the help file corrects the type of the parameter. |
src/Compute/Compute/Generated/Models/PSProximityPlacementGroup.cs
Outdated
Show resolved
Hide resolved
src/Compute/Compute/Generated/ProximityPlacementGroup/ProximityPlacementGroupGetMethod.cs
Outdated
Show resolved
Hide resolved
I understand your point. I was talking about the existing breaking change in your module. After discussion, we think we can move on. For your current PR, you include several things
It's better to split your pr if you want part of them to be included into this release. |
|
@msJinLei I updated the PR to hide the breaking change. Thanks. |
|
@hyonholee The change of AutomaticRepairsPolicy also cause a breaking change. |
Thanks |
|
@msJinLei I updated the PR. Thanks. |
|
@hyonholee Please rebase your commits to the latest master. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
[Compute] ColocationStatus for PPG.
Add ColocationStatus parameter to Get-AzProximityPlacementGroup cmdlet.
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/431
(This part was missing in the last release.)
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added