Skip to content

Conversation

@hyonholee
Copy link
Contributor

@hyonholee hyonholee commented Dec 27, 2019

Add ColocationStatus parameter to Get-AzProximityPlacementGroup cmdlet.

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/431
(This part was missing in the last release.)

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@msJinLei msJinLei self-assigned this Dec 30, 2019
@hyonholee
Copy link
Contributor Author

@msJinLei Hi, there is no breaking change in this PR. The line you mentioned is just a help file update. The existing help file is incorrect. Also, the change of the help file corrects the type of the parameter.

@msJinLei msJinLei changed the base branch from master to Release-2020-01-07 December 31, 2019 05:39
@msJinLei msJinLei changed the base branch from Release-2020-01-07 to master December 31, 2019 06:42
@msJinLei
Copy link
Contributor

@msJinLei Hi, there is no breaking change in this PR. The line you mentioned is just a help file update. The existing help file is incorrect. Also, the change of the help file corrects the type of the parameter.

I understand your point. I was talking about the existing breaking change in your module. After discussion, we think we can move on.

For your current PR, you include several things

  • update sdk version
  • change return property type
  • add switch parameter
  • fix help md file

It's better to split your pr if you want part of them to be included into this release.

@hyonholee
Copy link
Contributor Author

@msJinLei I updated the PR to hide the breaking change. Thanks.

@msJinLei msJinLei changed the base branch from master to Release-2020-01-07 January 2, 2020 05:49
@msJinLei
Copy link
Contributor

msJinLei commented Jan 2, 2020

@hyonholee The change of AutomaticRepairsPolicy also cause a breaking change.

Remove-AzVmssDiagnosticsExtension 3010 The property 'MaxInstanceRepairsPercent' of type 'Microsoft.Azure.Management.Compute.Models.AutomaticRepairsPolicy' has been removed.

@msJinLei
Copy link
Contributor

msJinLei commented Jan 2, 2020

@hyonholee

  • Please pull the latest version master of azure powershell
  • Run the version controller tool as the following to ensure no breaking change for your module.
PS D:\workspace\azure-powershell\tools> .\RunVersionController.ps1 -ModuleName "Az.Compute"
Bumping version for Az.Compute...
Detected below 1 breack change(s):
Remove-AzVmssDiagnosticsExtension 3010 The property 'MaxInstanceRepairsPercent' of type 'Microsoft.Azure.Management.Compute.Models.AutomaticRepairsPolicy' has been removed.
Updating version for Az.Compute from 3.2.0 to 4.0.0
Finished bumping version Az.Compute

Validating version bump for Az.Compute...
The version of Az.Compute has not been updated.

Thanks

@hyonholee
Copy link
Contributor Author

@msJinLei I updated the PR. Thanks.

@msJinLei msJinLei changed the base branch from Release-2020-01-07 to master January 6, 2020 06:17
@msJinLei
Copy link
Contributor

msJinLei commented Jan 6, 2020

@hyonholee Please rebase your commits to the latest master.

@hyonholee
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@erich-wang erich-wang merged commit 47d9fb3 into Azure:master Jan 9, 2020
@hyonholee hyonholee deleted the december branch January 17, 2020 19:54
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
[Compute] ColocationStatus for PPG.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants