Skip to content

Make -Scope optional in *-AzPolicyAssignment cmdlets #10852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 10, 2020
Merged

Make -Scope optional in *-AzPolicyAssignment cmdlets #10852

merged 5 commits into from
Jan 10, 2020

Conversation

@mentat9
Copy link
Member

@mentat9 mentat9 commented Jan 9, 2020

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@mentat9 mentat9 requested review from pilor and robga and removed request for pilor January 9, 2020 02:43
pilor
pilor reviewed Jan 9, 2020
View reviewed changes
pilor
pilor previously approved these changes Jan 9, 2020
View reviewed changes
@isra-fel isra-fel self-assigned this Jan 10, 2020
@mentat9
Copy link
Member Author

mentat9 commented Jan 10, 2020

Sorry, forgot to update the markdown help files until now.

isra-fel
isra-fel approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@isra-fel isra-fel merged commit ad439f0 into Azure:master Jan 10, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
@isra-fel
Merge pull request Azure#10852 from mentat9/master
a697048 
Make -Scope optional in *-AzPolicyAssignment cmdlets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel isra-fel approved these changes

@robga robga Awaiting requested review from robga

+1 more reviewer

@pilor pilor pilor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@isra-fel isra-fel

Labels

needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mentat9 @pilor @isra-fel