Fix New-AzSqlDatabaseSecondary existing database name check #10908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredmoo
previously approved these changes
Jan 15, 2020
jaredmoo
reviewed
Jan 15, 2020
| try | ||
| { | ||
| ModelAdapter.GetDatabase(this.PartnerResourceGroupName, this.PartnerServerName, this.DatabaseName); | ||
| ModelAdapter.GetDatabase(this.PartnerResourceGroupName, this.PartnerServerName, string.IsNullOrEmpty(this.PartnerDatabaseName) ? this.DatabaseName : this.PartnerDatabaseName); |
Contributor
There was a problem hiding this comment.
Consider extracting method to get effective partner database name.
isra-fel
requested changes
Jan 19, 2020
Member
isra-fel
left a comment
isra-fel
left a comment
There was a problem hiding this comment.
Hi @bradrich-msft the change looks good to me. Please add an entry to ChangeLog.md (as the PR template said) then I can get it merged. Thanks
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
closing in favor of #10983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fix. New-AzSqlDatabaseSecondary was checking existence of source database instead of target database.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added