Skip to content

Conversation

@amolagar5
Copy link
Contributor

@amolagar5 amolagar5 commented Feb 22, 2020

Description

Update sql server AAD Admin to use 2019-06-01-preview API

Pending: help and md files.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms
Copy link
Contributor

Hi @amolagar5, if youo need any help about generate help file. Please ask us as you wish.

@amolagar5
Copy link
Contributor Author

Help files have been added and swagger.NET checked in.

@amolagar5 amolagar5 changed the title [Do Not Merge]Update sql server AAD Admin to use 2019-06-01-preview API. [Ready for review and merge]Update sql server AAD Admin to use 2019-06-01-preview API. Feb 25, 2020
@wyunchi-ms wyunchi-ms self-assigned this Feb 26, 2020
@wyunchi-ms wyunchi-ms changed the title [Ready for review and merge]Update sql server AAD Admin to use 2019-06-01-preview API. Update sql server AAD Admin to use 2019-06-01-preview API. Feb 26, 2020
@wyunchi-ms
Copy link
Contributor

Hi @amolagar5 could you please take a look at the CI? The build is failed.

@amolagar5 amolagar5 changed the title Update sql server AAD Admin to use 2019-06-01-preview API. Update sql server AAD Admin to use 2019-06-01-preview API Feb 26, 2020
@amolagar5
Copy link
Contributor Author

Hi @amolagar5 could you please take a look at the CI? The build is failed.
@wyunchi-ms sure. waiting for .NET sdk build to get published. there are some ARM APIs not released and thus preventing us from publishing the SDK publicly.

@wyunchi-ms
Copy link
Contributor

Hi @amolagar5 could you please take a look at the CI? The build is failed.
@wyunchi-ms sure. waiting for .NET sdk build to get published. there are some ARM APIs not released and thus preventing us from publishing the SDK publicly.

Please tell me when the .NET sdk is ready. Then we can merge this pr. Thanks!

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@amolagar5
Copy link
Contributor Author

@wyunchi-ms , Build succeeds after publishing the .NET sdk nuget package, save-build fails however, can you please take a look.

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms wyunchi-ms changed the base branch from master to release-2020-03-10 March 4, 2020 06:35
@wyunchi-ms wyunchi-ms merged commit dfdd43b into Azure:release-2020-03-10 Mar 4, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
Update sql server AAD Admin to use 2019-06-01-preview API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants