Added new cmdlets for flowLog resource #11193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wyunchi-ms
reviewed
Feb 26, 2020
| { | ||
| base.Execute(); | ||
|
|
||
| if (ParameterSetName.Contains("SetByResourceId")) |
Contributor
There was a problem hiding this comment.
It's better to set ParameterSetName as const and use string equal to check the condition.
| private void ValidateInput() | ||
| { | ||
| string[] splittedTargetResourceId = this.TargetResourceId.Split('/'); | ||
| if (splittedTargetResourceId.Count() < 9 || string.IsNullOrEmpty(splittedTargetResourceId[7]) || !splittedTargetResourceId[7].Equals("networkSecurityGroups", StringComparison.OrdinalIgnoreCase)) |
Contributor
There was a problem hiding this comment.
9 and 7 seems a magic number. It's better to create a function handle the logic of spliting StorageResourceId.
| return NetworkResourceManagerProfile.Mapper.Map<PSFlowLogResource>(flowLogResult); | ||
| } | ||
|
|
||
| private void ValidateInput() |
Contributor
There was a problem hiding this comment.
This method is same with AddAzNetworkWatcherFlowLogCommand, you can move it into base class and reuse it.
| string parent = flowLogInfo.ParentResource; | ||
| string[] tokens = parent.Split(new[] { '/' }, StringSplitOptions.RemoveEmptyEntries); | ||
|
|
||
| this.NetworkWatcherName = tokens[1]; |
Contributor
There was a problem hiding this comment.
What if tokens length is 0?
Contributor
|
Hi @irrogozh , could you please also add test case and help files for these cmdlets. |
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
wyunchi-ms
approved these changes
Mar 1, 2020
dingmeng-xue
pushed a commit
to dingmeng-xue/azure-powershell
that referenced
this pull request
Mar 29, 2020
Added new cmdlets for flowLog resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added