Skip to content

Conversation

@Cdoherty95
Copy link
Contributor

@Cdoherty95 Cdoherty95 commented Mar 30, 2020

Example 1 had Set-AzWebAppAccessRestriction as the cmdlet instead of Update-AzWebAppAccessRestrictionConfig.
Old Example 1:

PS C:\>Set-AzWebAppAccessRestriction -ResourceGroupName "Default-Web-WestUS" -Name "ContosoSite" -ScmSiteUseMainSiteRestrictionConfig

Corrected Example 1:

PS C:\>Update-AzWebAppAccessRestrictionConfig -ResourceGroupName "Default-Web-WestUS" -Name "ContosoSite" -ScmSiteUseMainSiteRestrictionConfig

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Example 1 had Set-AzWebAppAccessRestriction as the cmdlet instead of Update-AzWebAppAccessRestrictionConfig.
Old Example 1:
```
PS C:\>Set-AzWebAppAccessRestriction -ResourceGroupName "Default-Web-WestUS" -Name "ContosoSite" -ScmSiteUseMainSiteRestrictionConfig
```
Corrected Example 1:
```
PS C:\>Update-AzWebAppAccessRestrictionConfig -ResourceGroupName "Default-Web-WestUS" -Name "ContosoSite" -ScmSiteUseMainSiteRestrictionConfig
```
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@msftclas
Copy link

msftclas commented Mar 31, 2020

CLA assistant check
All CLA requirements met.

@msJinLei
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor

msJinLei commented Apr 1, 2020

@Cdoherty95 Please sign the CLA.

@Cdoherty95
Copy link
Contributor Author

Cdoherty95 commented Apr 8, 2020

@msJinLei My apologies on the delay in signing the CLA

@Cdoherty95 Cdoherty95 marked this pull request as draft April 15, 2020 00:19
@Cdoherty95 Cdoherty95 marked this pull request as ready for review April 15, 2020 00:20
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looking good for me.

@isra-fel isra-fel merged commit d82061c into Azure:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants