Skip to content

[Storage] change default action to make it align with swagger #11641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2020
Merged

[Storage] change default action to make it align with swagger #11641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f9b97b
[Storage] change default action to make it align with swagger
blueww Oct 21, 2019
c81536b
Merge branch 'master' into defaultaction2
blueww Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Storage/Storage.Management/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
- Additional information about change #1
-->
## Upcoming Release
* Skip duplicated rules when add NetworkRules, to avoid server failure
* Fixed #9880: Change NetWorkRule DefaultAction value defination to align with swagger.
- Update-AzStorageAccountNetworkRuleSet
Copy link
Contributor

@wyunchi-ms wyunchi-ms Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add the contents "Fixed Mismatch in the DefaultAction Enum values. #9880".
  2. We think Changed is consistent with other logs.

Copy link
Member Author

@blueww blueww Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change log fixed.

- Get-AzStorageAccountNetworkRuleSet
* Fixed #11624: Skip duplicated rules when add NetworkRules, to avoid server failure
- `Add-AzStorageAccountNetworkRule`

## Version 1.14.0
Expand Down
4 changes: 2 additions & 2 deletions src/Storage/Storage.Management/Models/PSNetworkRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ public enum PSNetWorkRuleBypassEnum
//Wrapper of NetworkRuleSet property DefaultAction
public enum PSNetWorkRuleDefaultActionEnum
{
Deny = 0,
Allow = 1
Allow = 0,
Deny = 1
}

//Wrapper of NetworkRule property Action
Expand Down
2 changes: 0 additions & 2 deletions src/Storage/Storage.Management/StorageAccount/UpdateAzureStorageAccountNetworkRuleSet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ public PSNetWorkRuleBypassEnum Bypass
}
}

public const string ChangeDesc = "The DefaultAction value will change in a future release from: Allow = 1, Deny = 0, to: Allow = 0, Deny = 1.";
[CmdletParameterBreakingChange("DefaultAction", ChangeDescription = ChangeDesc)]
[Parameter(
Mandatory = false,
HelpMessage = "Storage Account NetworkRule DefaultAction.")]
Expand Down