Skip to content

Conversation

@vidyadharijami
Copy link
Member

Description

Added private endpoint in vault cred file for Site Recovery service.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@wyunchi-ms
Copy link
Contributor

Hi @vidyadharijami , could you please resolve the conflicts?

@vidyadharijami
Copy link
Member Author

Hi @vidyadharijami , could you please resolve the conflicts?

Done

@vidyadharijami
Copy link
Member Author

@wyunchi-ms Could you please review this PR

@wyunchi-ms
Copy link
Contributor

Some test cases failed. Could you please take a look?

@vidyadharijami
Copy link
Member Author

Some test cases failed. Could you please take a look?

Hi @wyunchi-ms,
Can you please let me know how to check this and what all test cases failed.

Thanks,
Vidya

@wyunchi-ms
Copy link
Contributor

Please take a look at the error here. Is Microsoft.Azure.Management.RecoveryServices 4.3.0-preview published to Nuget?

@wyunchi-ms
Copy link
Contributor

@vidyadharijami

@vidyadharijami
Copy link
Member Author

Please take a look at the error here. Is Microsoft.Azure.Management.RecoveryServices 4.3.0-preview published to Nuget?

Yes. It's published to nuget.

@vidyadharijami
Copy link
Member Author

Hi @wyunchi-ms,

The Recovery services module is not updated in Test project and the backup client is not initialized in test project. Fixed these now and the tests ran successfully.

Can you please review the PR now.

@wyunchi-ms
Copy link
Contributor

@vidyadharijami , please revolve the conflicts. I have no permission to resolve it for you.

@vidyadharijami
Copy link
Member Author

@vidyadharijami , please revolve the conflicts. I have no permission to resolve it for you.

Resolved.

@isra-fel isra-fel self-assigned this May 6, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 7056018 into Azure:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants