-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Adding private endpoint in vault cred file for SRS #11675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding private endpoint in vault cred file for SRS #11675
Conversation
|
Can one of the admins verify this patch? |
|
Hi @vidyadharijami , could you please resolve the conflicts? |
Done |
src/RecoveryServices/RecoveryServices/Common/PSRecoveryServicesVaultClient.cs
Show resolved
Hide resolved
src/RecoveryServices/RecoveryServices/Common/PSRecoveryServicesVaultClient.cs
Show resolved
Hide resolved
src/RecoveryServices/RecoveryServices/Vault/GetAzureRmRecoveryServicesBackupProperty.cs
Show resolved
Hide resolved
src/RecoveryServices/RecoveryServices/Vault/SetAzureRmRecoveryServicesBackupProperties.cs
Show resolved
Hide resolved
|
@wyunchi-ms Could you please review this PR |
|
Some test cases failed. Could you please take a look? |
Hi @wyunchi-ms, Thanks, |
|
Please take a look at the error here. Is |
Yes. It's published to nuget. |
|
Hi @wyunchi-ms, The Recovery services module is not updated in Test project and the backup client is not initialized in test project. Fixed these now and the tests ran successfully. Can you please review the PR now. |
|
@vidyadharijami , please revolve the conflicts. I have no permission to resolve it for you. |
Resolved. |
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added private endpoint in vault cred file for Site Recovery service.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added