Skip to content

Conversation

@blueww
Copy link
Member

@blueww blueww commented Apr 29, 2020

Description

The design pass review:
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/464

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms wyunchi-ms self-assigned this Apr 29, 2020
@wyunchi-ms
Copy link
Contributor

We changed some StaticAnalysis rules. Please sync the latest changes from master and rerun the CI.

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

Hi @blueww , the test case has some issue related to time zone. Please convert it to UTC time.

@blueww
Copy link
Member Author

blueww commented Apr 30, 2020

@wyunchi-ms
The test case fixed, and CI passed.

@wyunchi-ms wyunchi-ms merged commit 4aa4220 into Azure:Az.Storage-preview-v2 Apr 30, 2020
blueww added a commit to wastoresh/azure-powershell that referenced this pull request May 3, 2020
* [Storage] Support ORS

* [Storage] Fix CI failure
blueww added a commit to wastoresh/azure-powershell that referenced this pull request May 6, 2020
* [Storage] Support ORS

* [Storage] Fix CI failure
@blueww blueww mentioned this pull request Aug 14, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants