Skip to content

Conversation

@blueww
Copy link
Member

@blueww blueww commented May 1, 2020

Description

design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/559
Most pass review, a new change in Get-AzRmStorageShare need review.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A parameter cannot be found that matches parameter name GetShareUsage

Copy link
Member Author

@blueww blueww May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
Plan to add -GetShareUsage in the PR, but remove since server bug.
Product code is removed, but forget to remove test code.
Now test code is removed.

@blueww blueww changed the base branch from Az.Storage-preview-v2 to Az.Storage-preview May 6, 2020 09:05
@blueww blueww force-pushed the ssd branch 2 times, most recently from baef7a0 to bf335e3 Compare May 6, 2020 09:08
@wyunchi-ms wyunchi-ms merged commit c9c93d9 into Azure:Az.Storage-preview May 6, 2020
@blueww blueww mentioned this pull request Jul 23, 2020
8 tasks
@blueww blueww mentioned this pull request Sep 24, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants