Skip to content

Conversation

@dingmeng-xue
Copy link
Member

Description

Update module list.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@dingmeng-xue dingmeng-xue requested a review from dcaro May 13, 2020 03:28
@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@dingmeng-xue dingmeng-xue changed the base branch from master to release-2020-05-18 May 13, 2020 03:38
@dcaro
Copy link
Contributor

dcaro commented May 13, 2020

Thanks for updating the list, I may have missed them but I believe that we are missing the following modules:

  • Az.Advisor - 1.1.1
  • Az.Maintenance - 1.0.0

dcaro
dcaro previously approved these changes May 13, 2020
Copy link
Contributor

@dcaro dcaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the two missing modules, the rest looks good to me.

@dingmeng-xue dingmeng-xue requested a review from VeryEarly May 13, 2020 07:07
@VeryEarly VeryEarly merged commit fe561af into Azure:release-2020-05-18 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants