Skip to content

Conversation

@chlahav
Copy link
Contributor

@chlahav chlahav commented May 31, 2020

Description

Adding various cmdlets to list and manage assessments related resources in Microsoft.Security RP (Az.Security)

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly
Copy link
Collaborator

Hi @chlahav ,

Do you have approved design? If yes please attach the link, if not, please raise a new design

@VeryEarly VeryEarly closed this Jun 1, 2020
@VeryEarly VeryEarly reopened this Jun 1, 2020
@VeryEarly VeryEarly self-assigned this Jun 1, 2020
@chlahav
Copy link
Contributor Author

chlahav commented Jun 1, 2020

hi @VeryEarly , we do have an approved design here

@VeryEarly
Copy link
Collaborator

hi @VeryEarly , we do have an approved design here

Sorry totally forgot I did that, will review this PR soon.

@azure-pipelines
Copy link
Contributor

Pull request contains merge conflicts.

Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check comments,
record new added scenario tests.
Because the SDK upgrade, it's likely some test cases need to be re-recorded.

Also please resolve merge conflict in order to enable CI checks

@chlahav chlahav force-pushed the master branch 3 times, most recently from 3846209 to f160446 Compare June 1, 2020 23:24
@VeryEarly VeryEarly merged commit 4a1b908 into Azure:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants