-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Resource] Add new parameters to the What-If cmdlets to support excluding change types #12039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
VeryEarly
merged 9 commits into
Azure:master
from
shenglol:arm-template-what-if-exclude-change-types
Jun 3, 2020
Merged
[Resource] Add new parameters to the What-If cmdlets to support excluding change types #12039
VeryEarly
merged 9 commits into
Azure:master
from
shenglol:arm-template-what-if-exclude-change-types
Jun 3, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch? |
VeryEarly
reviewed
Jun 2, 2020
...sourceManager/Implementation/Deployments/GetAzureSubscriptionDeploymentWhatIfResultCmdlet.cs
Outdated
Show resolved
Hide resolved
VeryEarly
reviewed
Jun 2, 2020
...Resources/ResourceManager/Implementation/Deployments/NewAzureSubscriptionDeploymentCmdlet.cs
Outdated
Show resolved
Hide resolved
VeryEarly
reviewed
Jun 2, 2020
...Implementation/ResourceGroupDeployments/GetAzureResourceGroupDeploymentWhatIfResultCmdlet.cs
Outdated
Show resolved
Hide resolved
VeryEarly
reviewed
Jun 2, 2020
...urceManager/Implementation/ResourceGroupDeployments/NewAzureResourceGroupDeploymentCmdlet.cs
Outdated
Show resolved
Hide resolved
VeryEarly
requested changes
Jun 2, 2020
Collaborator
VeryEarly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check comments,
is it possible to have test cases cover your code changes?
Contributor
Author
Yes. Added tests to cover the new parameter and the formatter. |
VeryEarly
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-ExcludeChangeTypesparameter toGet-AzDeploymentWhatIfResultandGet-AzResourceGroupDeploymentWhatIfResult-WhatIfExcludeChangeTypesparameter toNew-AzDeploymentandNew-AzResourceGroupDeploymentTest-Az*Deploymentcmdlets to show better error messagesThis addresses Azure/arm-template-whatif#53.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added