Skip to content

Conversation

@jafreck
Copy link
Member

@jafreck jafreck commented Jun 9, 2020

Description

Update Management SDK version to 11, add Identity property to BatchAccount.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only): PR here: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/626
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly self-assigned this Jun 10, 2020
@VeryEarly
Copy link
Collaborator

Hi @jafreck ,

Not sure why this worked before but seems like you need to include Az.Network in:
https://github.com/jafreck/azure-powershell/blob/feature/batch-2020-05-01/src/Batch/Batch.sln

[[-AutoStorageAccountId] <String>] [-PoolAllocationMode <PoolAllocationMode>] [-KeyVaultId <String>]
[-KeyVaultUrl <String>] [-Tag <Hashtable>] [-PublicNetworkAccess <PublicNetworkAccessType>]
[-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
[-Identity <BatchAccountIdentity>] [-DefaultProfile <IAzureContextContainer>] [<CommonParameters>]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to regen this doc

@jafreck
Copy link
Member Author

jafreck commented Jun 10, 2020

Hi @jafreck ,

Not sure why this worked before but seems like you need to include Az.Network in:
https://github.com/jafreck/azure-powershell/blob/feature/batch-2020-05-01/src/Batch/Batch.sln

I agree, not sure how this was possibly passing before unless the build pipeline preinstalled Az.Network. I will fix this so the tests run successfully.

@VeryEarly VeryEarly merged commit d98850b into Azure:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants