Skip to content

Conversation

@blueww
Copy link
Member

@blueww blueww commented Jun 24, 2020

Description

design pass review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/645

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly self-assigned this Jun 24, 2020
@blueww
Copy link
Member Author

blueww commented Jun 24, 2020

@isra-fel
The Mac build failed seems not related with my change. Please let me know if any change need from my side.

/Users/runner/.dotnet/sdk/2.1.807/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(137,5): error NETSDK1045: The current .NET SDK does not support targeting .NET Core 2.2. Either target .NET Core 2.1 or lower, or use a version of the .NET SDK that supports .NET Core 2.2. [/Users/runner/runners/2.170.1/work/1/s/tools/ScenarioTest.ResourceManager/ScenarioTest.ResourceManager.csproj] [/Users/runner/runners/2.170.1/work/1/s/build.proj]

@isra-fel
Copy link
Member

@blueww this should be an issue with azure devops. We are working on it.

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit d9d94d7 into Azure:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants