Skip to content

Conversation

@aladdindoc
Copy link
Contributor

  • Add Aladdin crafted examples.

	- Add new examples to the following modules:
		Network
@aladdindoc aladdindoc requested a review from anton-evseev as a code owner July 1, 2020 21:50
@adxsdkps
Copy link
Collaborator

adxsdkps commented Jul 1, 2020

Can one of the admins verify this patch?

@VeryEarly VeryEarly requested a review from mikefrobbins July 2, 2020 04:33
@VeryEarly VeryEarly self-assigned this Jul 2, 2020
Copy link
Contributor

@mikefrobbins mikefrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcaro Can you review my comments and see what you think?


<!-- Aladdin Generated Example -->
```powershell
New-AzApplicationGatewayBackendHttpSetting -CookieBasedAffinity Enabled -Name 'Setting01' -PickHostNameFromBackendAddress -Port 80 -Probe <PSApplicationGatewayProbe> -Protocol https -RequestTimeout <Int32>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Seems odd to use port 80 with HTTPS (SSL).

Copy link
Contributor

@dcaro dcaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes looking good.

Copy link
Contributor

@mikefrobbins mikefrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aladdindoc
Copy link
Contributor Author

#sign-off

@dcaro dcaro removed the request for review from anton-evseev July 17, 2020 21:05
@dingmeng-xue
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dingmeng-xue dingmeng-xue merged commit 8b6b73c into Azure:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants