-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Aladdin generated examples for Network #12306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aladdin generated examples for Network #12306
Conversation
aladdindoc
commented
Jul 1, 2020
- Add Aladdin crafted examples.
- Add new examples to the following modules: Network
|
Can one of the admins verify this patch? |
mikefrobbins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcaro Can you review my comments and see what you think?
|
|
||
| <!-- Aladdin Generated Example --> | ||
| ```powershell | ||
| New-AzApplicationGatewayBackendHttpSetting -CookieBasedAffinity Enabled -Name 'Setting01' -PickHostNameFromBackendAddress -Port 80 -Probe <PSApplicationGatewayProbe> -Protocol https -RequestTimeout <Int32> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Seems odd to use port 80 with HTTPS (SSL).
src/Network/Network/help/New-AzFirewallPolicyApplicationRule.md
Outdated
Show resolved
Hide resolved
src/Network/Network/help/New-AzApplicationGatewayPrivateLinkIpConfiguration.md
Outdated
Show resolved
Hide resolved
dcaro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes looking good.
mikefrobbins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
#sign-off |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |