Skip to content

Reserved Instances- update autocomplete to reflect new reserved resource types #12376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyunchi-ms merged 3 commits into from
Jul 13, 2020
Merged

Reserved Instances- update autocomplete to reflect new reserved resource types #12376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee89b8d
Added new reservedResourceTypes
Jul 10, 2020
39e42a9
Updated changelog
Jul 10, 2020
1c3ab30
changed formatting
Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Reservations/Reservations/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
- Additional information about change #1
-->
## Upcoming Release
* Added new reserved resource types.

## Version 0.8.2
* Spelling fix in the docs.
Expand Down
4 changes: 3 additions & 1 deletion src/Reservations/Reservations/Cmdlets/Calculate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ namespace Microsoft.Azure.Commands.Reservations.Cmdlets
public class Calculate : AzureReservationsCmdletBase
{
[Parameter(Mandatory = true)]
[PSArgumentCompleter("VirtualMachines", "SqlDatabases", "SuseLinux", "CosmosDb", "RedHat", "SqlDataWarehouse", "VMwareCloudSimple", "RedHatOsa")]
[PSArgumentCompleter("VirtualMachines", "SqlDatabases", "SuseLinux", "CosmosDb", "RedHat", "SqlDataWarehouse",
"VMwareCloudSimple", "RedHatOsa", "Databricks", "AppService", "ManagedDisk", "BlockBlob", "RedisCache",
"AzureDataExplorer", "MySql", "MariaDb", "PostgreSql", "DedicatedHost", "SapHana")]
[ValidateNotNullOrEmpty]
public string ReservedResourceType { get; set; }

Expand Down
4 changes: 3 additions & 1 deletion src/Reservations/Reservations/Cmdlets/GetCatalog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ public class GetCatalog : AzureReservationsCmdletBase
public Guid SubscriptionId { get; set; }

[Parameter(Mandatory = true)]
[PSArgumentCompleter("VirtualMachines", "SqlDatabases", "SuseLinux", "CosmosDb")]
[PSArgumentCompleter("VirtualMachines", "SqlDatabases", "SuseLinux", "CosmosDb", "RedHat", "SqlDataWarehouse",
"VMwareCloudSimple", "RedHatOsa", "Databricks", "AppService", "ManagedDisk", "BlockBlob", "RedisCache",
"AzureDataExplorer", "MySql", "MariaDb", "PostgreSql", "DedicatedHost", "SapHana")]
[ValidateNotNullOrEmpty]
public string ReservedResourceType { get; set; }

Expand Down
4 changes: 3 additions & 1 deletion src/Reservations/Reservations/Cmdlets/Purchase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ public class Purchase : AzureReservationsCmdletBase
public string ReservationOrderId { get; set; }

[Parameter(Mandatory = true)]
[PSArgumentCompleter("VirtualMachines", "SqlDatabases", "SuseLinux", "CosmosDb", "RedHat", "SqlDataWarehouse", "VMwareCloudSimple", "RedHatOsa")]
[PSArgumentCompleter("VirtualMachines", "SqlDatabases", "SuseLinux", "CosmosDb", "RedHat", "SqlDataWarehouse",
"VMwareCloudSimple", "RedHatOsa", "Databricks", "AppService", "ManagedDisk", "BlockBlob", "RedisCache",
"AzureDataExplorer", "MySql", "MariaDb", "PostgreSql", "DedicatedHost", "SapHana")]
[ValidateNotNullOrEmpty]
public string ReservedResourceType { get; set; }

Expand Down