Skip to content

Conversation

@anusapan
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms
Copy link
Contributor

Hi @anusapan , tools/LocalFeed/Microsoft.Azure.Devices.Shared.1.20.1.1.nupkg is not need in this PR, please remove it. And why these two sdk is needed? To fix bug?

@anusapan
Copy link
Contributor Author

anusapan commented Jul 14, 2020

@wyunchi-ms
To enable some feature that is available in the latest nupkg of "Microsoft.Azure.Devices" but it is using Newtonsoft v12+ and in PowerShell, the allowed max version of NewtownSoft is 10.0.3. So to resolve this, I have created a local nupkg of "Microsoft.Azure.Devices" and its dependent SDK ("Microsoft.Azure.Devices.Shared") with allowable serializer version.

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms wyunchi-ms merged commit f532b9b into Azure:master Jul 15, 2020
@anusapan anusapan deleted the custom-nupkg branch July 15, 2020 20:06
wyunchi-ms added a commit that referenced this pull request Jul 16, 2020
wyunchi-ms added a commit that referenced this pull request Jul 16, 2020
Co-authored-by: wyunchi-ms <yunwang@microsoft.com>
@anusapan anusapan restored the custom-nupkg branch July 16, 2020 18:01
@anusapan anusapan deleted the custom-nupkg branch November 20, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants