Skip to content

[StackHCI] Add necessary files #12398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dingmeng-xue merged 2 commits into from
Jul 17, 2020
Merged

[StackHCI] Add necessary files #12398

dingmeng-xue merged 2 commits into from
Jul 17, 2020

Conversation

@wyunchi-ms
Copy link
Contributor

@wyunchi-ms wyunchi-ms commented Jul 15, 2020 •
edited
Loading

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Jul 15, 2020

Can one of the admins verify this patch?

@wyunchi-ms wyunchi-ms force-pushed the wyunchi/HCI branch 2 times, most recently from 085dd10 to b3a8f27 Compare July 16, 2020 09:08
@wyunchi-ms
Copy link
Contributor Author

wyunchi-ms commented Jul 16, 2020

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Jul 16, 2020

Azure Pipelines successfully started running 3 pipeline(s).

dingmeng-xue
dingmeng-xue reviewed Jul 17, 2020
View reviewed changes
dingmeng-xue
dingmeng-xue previously requested changes Jul 17, 2020
View reviewed changes
Copy link
Member

@dingmeng-xue dingmeng-xue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help to update module list.

@wyunchi-ms
Copy link
Contributor Author

wyunchi-ms commented Jul 17, 2020

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Jul 17, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor Author

wyunchi-ms commented Jul 17, 2020

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Jul 17, 2020

Azure Pipelines successfully started running 3 pipeline(s).

dingmeng-xue
dingmeng-xue approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@dingmeng-xue dingmeng-xue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dingmeng-xue dingmeng-xue merged commit faf178c into master Jul 17, 2020
@wyunchi-ms wyunchi-ms deleted the wyunchi/HCI branch August 21, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dingmeng-xue dingmeng-xue dingmeng-xue approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wyunchi-ms @adxsdkps @dingmeng-xue