Validate input region, add support for West Europe and Canary endpoints #12427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first version of Az.AzureStackHCI script based cmdlets that provide functionality to register and unregister an on-premise Hyper-Converged Infrastructure deployment with Azure.
Addressing PR feedback to make the Azure Stack HCI module and cmdlet names consistent with Azure PowerShell guidelines.
HCI cloud billing service is now onboarded to East US. Also the DogFood one in West US is renamed to explcitily indicate the region.
Need the Azure PS fork to be in sync
Collaborator
|
Can one of the admins verify this patch? |
wyunchi-ms
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The input region where the HCI resource is created needs to be validated. Also we have onboarded to West Europe, whose endpoint needs to be supported.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added