Encryption at host param #12514
Merged
Encryption at host param #12514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig and Update-AzVM (#12479) * Adding SecurityProfile and EncryptionAtHost property * Removing deprecated package * Adding back windowsazure.storage library * reverting to version 9.3 * commenting out check for now * commenting out test case * Fixing powershell script * Changing Compute Version for upstream * fixing test * Commenting out test * Adding change log and helpdocs * Testing and other changes
… should be very similar to New-Azvmss.
…e-powershell into encryptionAtHostParam
Collaborator
|
Can one of the admins verify this patch? |
grizzlytheodore
commented
Jul 28, 2020
grizzlytheodore
commented
Jul 28, 2020
src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs
Outdated
Show resolved
Hide resolved
grizzlytheodore
commented
Jul 28, 2020
src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetUpdateMethod.cs
Outdated
Show resolved
Hide resolved
fixing type on ln 245
haagha
reviewed
Jul 28, 2020
src/Compute/Compute/Generated/VirtualMachineScaleSet/Config/NewAzureRmVmssConfigCommand.cs
Outdated
Show resolved
Hide resolved
grizzlytheodore
added
Do Not Merge 🚫
Do Not Squash 🚫
isra-fel
requested changes
Jul 30, 2020
src/Compute/Compute/VirtualMachine/Operation/NewAzureVMCommand.cs
Outdated
Show resolved
Hide resolved
Member
|
Hey, BTW what's the reason for "do not merge" and "do not squash" labels? |
grizzlytheodore
removed
the
Do Not Squash 🚫
Contributor
Author
|
@isra-fel we've resolved all your comments and some more. for the labels, I had a wrong understanding of squashing, so I've removed that. And for 'do not merge' we have a demo for this feature with the PMs tomorrow and I didn't want this merged yet in case they have some additional suggestions. |
Member
|
I see. The changes look good to me for now. |
grizzlytheodore
commented
Jul 31, 2020
grizzlytheodore
commented
Jul 31, 2020
Contributor
Author
|
@isra-fel i have removed the Do-not-merge label. Please review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/686
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added