Skip to content

Conversation

@idear1203
Copy link
Contributor

Description

This change introduces a version parameter for Sql Pools to allow customers to provision the latest version of SqlPools. It also introduces the SqlDatabase resource and allows basic CRUD operations for it. Sql Pools make up the compute and can be scaled, connected to, and used to issue queries. The queries operate on the data contained in the SqlDatabase. SqlPools can be used to query different Sql Databases within the same Synapse workspace.

Design review link: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/673

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

adxsdkps commented Aug 7, 2020

Can one of the admins verify this patch?

@idear1203
Copy link
Contributor Author

Please DO NOT merge this PR. Currently we are using a self-built SDK, we will switch to a official bit that will be available next week. Other than this issue, the PR is ready for a review.

phkanekal
phkanekal previously approved these changes Aug 7, 2020
@isra-fel isra-fel self-assigned this Aug 10, 2020
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just need to replace the SDK

@idear1203
Copy link
Contributor Author

@isra-fel I switched to the official SDK package. Could you please take a look again?

@isra-fel
Copy link
Member

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel merged commit 2ab1287 into Azure:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants