Skip to content

Conversation

@dingmeng-xue
Copy link
Member

@dingmeng-xue dingmeng-xue commented Aug 13, 2020

Description

Remove log4net because it impacts assembly analysis.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Collaborator

Can one of the admins verify this patch?

@dingmeng-xue dingmeng-xue changed the title Remove log4dotnet lib Remove log4net lib Aug 13, 2020
@isra-fel isra-fel self-assigned this Aug 14, 2020
@isra-fel isra-fel merged commit e6c9641 into Azure:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants