[Storage] Add breaking change type #13118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
requested changes
Oct 9, 2020
Member
There was a problem hiding this comment.
Generally LGTM
You'll need to suppress the detected breaking change errors, see https://github.com/Azure/azure-powershell/blob/master/documentation/Debugging-StaticAnalysis-Errors.md#breaking-changes
Member
There was a problem hiding this comment.
nit: format
Suggested change
| *Removed obsolete property RestorePolicy.LastEnabledTime | |
| * Removed obsolete property RestorePolicy.LastEnabledTime |
Member
|
Looks like the conflict needs to be resolved from command line |
isra-fel
previously approved these changes
Oct 10, 2020
Member
|
/azp run azure-powershell - powershell-core |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
isra-fel
added
Waiting for CI 
Contains Breaking Change
Member
Author
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run azure-powershell - powershell-core |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run azure-powershell - powershell-core |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
wyunchi-ms
previously approved these changes
Oct 15, 2020
wyunchi-ms
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add some breaking change for output type, and remove the before added breaking change warning message
target to 10/27 release.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added