Add TranslatedFqdn option for Azure Firewall Policy NAT Rule #13238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeryEarly
reviewed
Oct 16, 2020
Collaborator
VeryEarly
left a comment
VeryEarly
left a comment
There was a problem hiding this comment.
let's wait for SDK to be published
src/Network/Network/AzureFirewallPolicy/NatRule/NewAzureFirewallPolicyNatRuleCommand.cs
Outdated
Show resolved
Hide resolved
tejasshah7
force-pushed
the
tesha/FwPlcyTranslatedFqdn
branch
2 times, most recently
from
e644ff1 to
f293c75
Compare
Collaborator
|
PR looks good, wait for SDK to be published. |
tejasshah7
force-pushed
the
tesha/FwPlcyTranslatedFqdn
branch
from
f293c75 to
387df77
Compare
tejasshah7
force-pushed
the
tesha/FwPlcyTranslatedFqdn
branch
from
387df77 to
ef7d45c
Compare
Collaborator
|
one quick tip: you can run static analysis in your local and resolve issues before push to remote. dotnet msbuild /t:build |
tejasshah7
force-pushed
the
tesha/FwPlcyTranslatedFqdn
branch
4 times, most recently
from
30b7b57 to
176233a
Compare
tejasshah7
force-pushed
the
tesha/FwPlcyTranslatedFqdn
branch
from
176233a to
4088930
Compare
tejasshah7
force-pushed
the
tesha/FwPlcyTranslatedFqdn
branch
from
4088930 to
9fa9ee4
Compare
VeryEarly
approved these changes
Nov 5, 2020
dingmeng-xue
added a commit
that referenced
this pull request
Nov 13, 2020
* Updates project with generated nuget package from july release .net sdk and added new global load balancing properties to associated loadbalancer and ipaddress commands * Updated Network changelog.md * Added tests, new cross region loadbalancer backend address config command, global tier to ip prefix, and ip prefix parameter to create loadbalancer frontend ip config command * updated changelog * removed frontend paramter from original backendaddress config command * removed new cross region loadbalancer backend address config command, added loadbalancer frontend ip config paramater to existing new backend address config command and updated help files for the new paramter and ip prefix paramter on loadbalancer frontend ip config command * Added ipprefix(id) parameters to set and add commands for loadbalancer frontend ip config * addressing comments * removing white spaces * reverted powershell to pwsh * updated backend address model with new property * ran automation for help files * fixed changelog syntax * add pass by value option to new, set, and add commands for frontend ip config and added test example * Updated ApiVersion from 2020-05-01 to 2020-07-01 (#13357) Updated ApiVersion from 2020-05-01 to 2020-07-01 * Added officially published SDK (#13409) * updating nuget package * updating nuget package * updating CreateSubresourcesOnEmptyLoadBalancer UT to comply with changes in new network SDK * Add TranslatedFqdn option for Azure Firewall Policy NAT Rule (#13238) * Add TranslatedFqdn option for Azure Firewall Policy NAT Rule * Fixing LB test * Fixed more LB tests * deleted local nugets * removed 20.2.0 nuget package and modules.zip * adding examples for new parameters * update azvirtualrouter (#13455) * removing space * Add Get-AzVirtualRouterPeerAdvertisedRoute and Get-AzVirtualRouterPeerLearnedRoute with warning messageVr peer (#13462) * Add Get-AzVirtualRouterPeerAdvertisedRoute and Get-AzVirtualRouterPeerLearnedRoute with warning message * Delete Authentication - Backup.csproj * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md * Update ChangeLog.md Co-authored-by: Yabo Hu <yabhu@microsoft.com> * Adding allocation method fix to Test-PublicIpAddressCRUD-StandardSkuGlobalTier * copied recorded sessions for new tests into project session records folder * updating TestSetLoadBalancerCRUDPublicBasicSku session record * updated session record for TestLoadBalancerBackendPoolCreate * Updated session record for TestGlobalLoadBalancerBackendPoolCreate Co-authored-by: Kayden <kawilki@microsoft.com> Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com> Co-authored-by: Ranjani Hatti <57383674+v-shhatt@users.noreply.github.com> Co-authored-by: Mikhail <mikhail.tryakhov@gmail.com> Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com> Co-authored-by: litchiyangMSFT <64560090+litchiyangMSFT@users.noreply.github.com> Co-authored-by: Yabo Hu <yabhu@microsoft.com>
isra-fel
pushed a commit
that referenced
this pull request
Dec 25, 2020
* add firewall policy new commands * SDK * network test project * firewall policy premium test * add UT * finish UT * help files * add nuget package * CR * Updated ApiVersion from 2020-05-01 to 2020-07-01 (#13357) Updated ApiVersion from 2020-05-01 to 2020-07-01 * Added officially published SDK (#13409) * change to new SDK version * Add TranslatedFqdn option for Azure Firewall Policy NAT Rule (#13238) * Add TranslatedFqdn option for Azure Firewall Policy NAT Rule * Fixing LB test * Fixed more LB tests * fixes * fix * fix * Added WebCategories * Premium sets and TLS * Added .md files for changes * Added change log for premiume set changes * changeLog.md from adi * added shouldProcess and fixed variable name * changing -SignatureOverrides to -SignatureOverride * re-record tests and remove FirewallPolicySslCert.pfx as it wasn't needed Co-authored-by: Adi Griever <adgrieve@microsoft.com> Co-authored-by: Ranjani Hatti <57383674+v-shhatt@users.noreply.github.com> Co-authored-by: Mikhail <mikhail.tryakhov@gmail.com> Co-authored-by: tejasshah7 <49326906+tejasshah7@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add TranslatedFqdn option for Azure Firewall Policy NAT Rule
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added