Skip to content

Get-AzVm filter by Name prior to checking for throttling #13437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
msJinLei merged 19 commits into from
Nov 23, 2020
Merged

Get-AzVm filter by Name prior to checking for throttling #13437

msJinLei merged 19 commits into from
Nov 23, 2020

Conversation

@Sandido
Copy link
Contributor

@Sandido Sandido commented Nov 6, 2020 •
edited
Loading

Work for https://msazure.visualstudio.com/One/_workitems/edit/8555684
and improvement to a previous test method's synopsis.

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@isra-fel isra-fel assigned isra-fel and unassigned isra-fel Nov 9, 2020
@Sandido Sandido changed the title Get-AzVm, attempt to iterate over resource groups in Az.Compute Get-AzVm filter by Name prior to checking for throttling Nov 18, 2020
@Sandido Sandido marked this pull request as ready for review November 18, 2020 21:47
@Sandido Sandido requested a review from MS-syh2qs as a code owner November 18, 2020 21:47
@Sandido Sandido requested review from isra-fel and msJinLei November 18, 2020 21:50
@grizzlytheodore
Copy link
Contributor

grizzlytheodore commented Nov 18, 2020

LGTM!

@Sandido
Copy link
Contributor Author

Sandido commented Nov 19, 2020

/azp run powershell-core

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Nov 19, 2020

No pipelines are associated with this pull request.

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Nov 19, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei msJinLei merged commit 0e6d853 into master Nov 23, 2020
@isra-fel isra-fel deleted the SandidoGetAzVM100 branch November 23, 2020 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bilaakpan-ms bilaakpan-ms Awaiting requested review from bilaakpan-ms

@dkulkarni-ms dkulkarni-ms Awaiting requested review from dkulkarni-ms

@haagha haagha Awaiting requested review from haagha

@madewithsmiles madewithsmiles Awaiting requested review from madewithsmiles

@MS-syh2qs MS-syh2qs Awaiting requested review from MS-syh2qs

@isra-fel isra-fel Awaiting requested review from isra-fel

2 more reviewers

@grizzlytheodore grizzlytheodore grizzlytheodore left review comments

@msJinLei msJinLei msJinLei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Sandido @grizzlytheodore @msJinLei @azuresdkci @isra-fel