Skip to content

Move SignalR to release-2021-11-02 #16241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wyunchi-ms wants to merge 8 commits into from
Closed

Move SignalR to release-2021-11-02 #16241

wyunchi-ms wants to merge 8 commits into from

Conversation

@wyunchi-ms
Copy link
Contributor

@wyunchi-ms wyunchi-ms commented Oct 27, 2021

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms
Copy link
Contributor Author

wyunchi-ms commented Oct 27, 2021

/azp run

@azure-pipelines
Copy link
Contributor

azure-pipelines bot commented Oct 27, 2021

Azure Pipelines successfully started running 3 pipeline(s).

@BethanyZhou BethanyZhou added this to the Oct 2021 (2021-11-02) milestone Oct 27, 2021
@BethanyZhou
Copy link
Contributor

BethanyZhou commented Oct 27, 2021

Is there any PR posted to generation branch?

@BethanyZhou
Copy link
Contributor

BethanyZhou commented Oct 27, 2021

we should add change log in src/SignalR/SignalR/ChangeLog.md

BethanyZhou
BethanyZhou reviewed Oct 27, 2021
View reviewed changes
tools/GeneratedModuleList.txt Outdated
@@ -39,6 +39,7 @@ Az.ProviderHub
Az.Purview
Az.RedisEnterpriseCache
Az.ResourceMover
Az.SignalR
Copy link
Contributor

@BethanyZhou BethanyZhou Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Az.WebPubSub should be removed.

tools/CreateMappings_rules.json
@@ -703,6 +703,6 @@
},
{
"regex": "WebPubSub",
"alias": "WebPubSub"
"alias": "Web PubSub"
Copy link
Contributor

@BethanyZhou BethanyZhou Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this?

@BethanyZhou
Copy link
Contributor

BethanyZhou commented Oct 28, 2021

#16251
Close as created another PR

@BethanyZhou BethanyZhou deleted the codegen/SignalR branch October 28, 2021 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BethanyZhou BethanyZhou BethanyZhou left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Oct 2021 (2021-11-02)

Development

Successfully merging this pull request may close these issues.

5 participants

@wyunchi-ms @BethanyZhou @azure-powershell-bot @dingmeng-xue