Skip to content

Conversation

@grizzlytheodore
Copy link
Contributor

@grizzlytheodore grizzlytheodore commented Jun 10, 2022

Description

it is adding 'restrictionInfo' column to table xml, and removing not useful columns. It is not a breaking change because returned object did not change, it is only what is being printed.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly assigned VeryEarly and unassigned VeryEarly Jun 14, 2022
@grizzlytheodore grizzlytheodore marked this pull request as ready for review August 3, 2022 23:09
@grizzlytheodore grizzlytheodore changed the title Feature/cplat improve SKU output improved printed output for Get-AzComputeResourceSku Aug 3, 2022
@isra-fel isra-fel self-assigned this Aug 4, 2022
@grizzlytheodore
Copy link
Contributor Author

@isra-fel can this be review/merged?

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@isra-fel isra-fel merged commit 7735306 into main Aug 9, 2022
@isra-fel isra-fel deleted the feature/cplat-improveSkuOutput branch August 9, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants