Skip to content

Conversation

@Ab0907
Copy link
Contributor

@Ab0907 Ab0907 commented Aug 5, 2022

Description

Get-AzAutomationJob failed for some jobIds with the error - "Conversion from JSON failed with error: Unexpected character encountered while parsing value: D. Path '', line 0, position 0."
The bug was specific to Powershell 7 and was occurring due to ConvertFrom-Json not identifying strings without quotes around them

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

@ghost ghost added the customer-reported label Aug 5, 2022
@ghost
Copy link

ghost commented Aug 5, 2022

Thank you for your contribution Ab0907! We will review the pull request and get back to you soon.

@isra-fel isra-fel self-assigned this Aug 5, 2022
@isra-fel
Copy link
Member

isra-fel commented Aug 8, 2022

@Ab0907 please resolve the conflict in ChangeLog.md that's blocking CI.
Also, join Azure orgnization by https://aka.ms/AzureGitHub

@Ab0907
Copy link
Contributor Author

Ab0907 commented Aug 8, 2022

Joined Azure org and conflict blocking CLI has been resolved

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the test cases.
Also, consider using AzurePSCmdlet.PowerShellVersion property to avoid duplication.

@Ab0907
Copy link
Contributor Author

Ab0907 commented Aug 9, 2022

Used AzurePSCmdlet.PowerShellVersion property to avoid duplication.

@isra-fel
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel merged commit 7bd1100 into Azure:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants