Skip to content

Conversation

@VeryEarly
Copy link
Collaborator

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

vidai-msft and others added 12 commits October 26, 2022 12:34
* initial dev, no good EL yet

* dev and trying to test

* diskfile stuff

* Update VirtualMachineScaleSetTests.ps1

* Update VirtualMachineScaleSetCreateOrUpdateMethod.cs

* Update NewAzureVMCommand.cs

* Update VirtualMachineTests.ps1

* test trying

* dev and test

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
* Move Compute to release-2022-11-01

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
* Move StackHCI to release-2022-11-01

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
* Added Az.Accounts version in telemetry of autorest-based module

* upgrade common version
* Generate autorest for IPv6FirewallRule

* Add IPv6 Powershell cmdlet

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
* revert #19865

* resolve conflict

* improve examples

* Update Get-AzFirewallLearnedIpPrefix.md
* gallery changes

* Changes for community gallery

* updated changelog

* help change

* get-azgalleryimageversion help

* Adding to required assemblies

* Fixing errors in PR

* fix help

* fix get-azgallery community parameter set

* bug fix

* update bug fix community gallery

* changes to community gallery permission

* Adding fixes

* adding vmstrategy

* docs

* update parameter set

* Adding breaking change exception

* changes suggested in comments

* undo help files

* Breaking change restore

* Updating help

* Update ChangeLog.md

Co-authored-by: Haider Agha <haagha@microsoft.com>
Co-authored-by: haagha <64601174+haagha@users.noreply.github.com>
Co-authored-by: Yunchi Wang <54880216+wyunchi-ms@users.noreply.github.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
* Move ConnectedKubernetes to main

* update changelog

* Update ChangeLog.md

Co-authored-by: lijinpei2008 <v-jinpel@microsoft.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
@VeryEarly VeryEarly added the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label Oct 28, 2022
@VeryEarly VeryEarly self-assigned this Oct 28, 2022
Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me

@BethanyZhou BethanyZhou merged commit f8779c8 into main Oct 31, 2022
@BethanyZhou BethanyZhou deleted the release-2022-11-01 branch October 31, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants