-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[MCP] Added Mcp node v23 support #28026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the MCP Server to support Node v23 while updating the internal schema and improving utility functions. Key changes include:
- Renaming the toolParameterSchema property from "description" to "text" in types.ts.
- Correcting a typo in the URL property within utils.ts.
- Refactoring JSON file loading in CodegenServer.ts and updating corresponding schema references.
- Adding a new script ("fresh") in package.json and updating README.md with integration instructions for GitHub Copilot Agent mode.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Mcp/src/types.ts | Updated schema property name from "description" to "text". |
| tools/Mcp/src/services/utils.ts | Fixed typo: corrected "dowwnload_url" to "download_url". |
| tools/Mcp/src/CodegenServer.ts | Refactored JSON file loading and updated schema property usage. |
| tools/Mcp/package.json | Introduced new script "fresh" to streamline build and startup. |
| tools/Mcp/README.md | Added instructions for integration with GitHub Copilot Agent mode. |
Comments suppressed due to low confidence (2)
tools/Mcp/src/types.ts:4
- The property was renamed from 'description' to 'text'. Please ensure that all consumers of this property are updated accordingly to maintain consistency.
text: string;
tools/Mcp/src/services/utils.ts:127
- The typo 'dowwnload_url' has been corrected to 'download_url'. Confirm that this change is reflected in all relevant parts of the code to prevent integration issues.
if (!exampleSet.has(ex.download_url)) {
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.