Skip to content

Conversation

@notyashhh
Copy link
Member

@notyashhh notyashhh commented Jun 25, 2025

Description

  • Latest node version v23 is supported in this MCP server.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings June 25, 2025 14:29
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

This comment was marked as outdated.

notyashhh and others added 3 commits June 26, 2025 00:48
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@notyashhh notyashhh changed the base branch from main to dev/mcp-server June 25, 2025 15:32
@notyashhh notyashhh requested a review from Copilot June 26, 2025 05:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the MCP Server to support Node v23 while updating the internal schema and improving utility functions. Key changes include:

  • Renaming the toolParameterSchema property from "description" to "text" in types.ts.
  • Correcting a typo in the URL property within utils.ts.
  • Refactoring JSON file loading in CodegenServer.ts and updating corresponding schema references.
  • Adding a new script ("fresh") in package.json and updating README.md with integration instructions for GitHub Copilot Agent mode.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/Mcp/src/types.ts Updated schema property name from "description" to "text".
tools/Mcp/src/services/utils.ts Fixed typo: corrected "dowwnload_url" to "download_url".
tools/Mcp/src/CodegenServer.ts Refactored JSON file loading and updated schema property usage.
tools/Mcp/package.json Introduced new script "fresh" to streamline build and startup.
tools/Mcp/README.md Added instructions for integration with GitHub Copilot Agent mode.
Comments suppressed due to low confidence (2)

tools/Mcp/src/types.ts:4

  • The property was renamed from 'description' to 'text'. Please ensure that all consumers of this property are updated accordingly to maintain consistency.
    text: string;

tools/Mcp/src/services/utils.ts:127

  • The typo 'dowwnload_url' has been corrected to 'download_url'. Confirm that this change is reflected in all relevant parts of the code to prevent integration issues.
                if (!exampleSet.has(ex.download_url)) {

@notyashhh notyashhh requested a review from VeryEarly June 26, 2025 05:46
@notyashhh notyashhh changed the title Mcp Server Enhancement Added Mcp node v23 support Jun 26, 2025
@notyashhh notyashhh requested a review from VeryEarly June 26, 2025 06:30
@VeryEarly VeryEarly changed the title Added Mcp node v23 support [MCP] Added Mcp node v23 support Jun 27, 2025
@VeryEarly VeryEarly merged commit d2e55b9 into dev/mcp-server Jun 27, 2025
12 checks passed
@VeryEarly VeryEarly deleted the yash/mcp-server branch June 27, 2025 03:53
@notyashhh notyashhh restored the yash/mcp-server branch July 1, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants