-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[MCP] Sync Code Generation MCP server to main branch #28703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Syncs a new Model Context Protocol (MCP) code generation server and related assets into the repository to support Azure PowerShell module scaffolding, code generation, example/test creation, and partner workflow automation.
- Adds MCP server implementation (TypeScript), tool/prompt/resource specs, response templates, logging, and utilities.
- Introduces asset templates (examples, tests, help READMEs) and README documentation for the MCP server.
- Includes build configuration (tsconfig.json, package.json) and minor cleanup in an existing test utility script.
Reviewed Changes
Copilot reviewed 38 out of 41 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Mcp/tsconfig.json | Adds TypeScript compiler configuration for the MCP server (contains invalid module target). |
| tools/Mcp/src/types.ts | Introduces interface type definitions (non‑conventional naming). |
| tools/Mcp/src/specs/specs.json | Defines MCP tool & prompt schemas (minor spelling issue). |
| tools/Mcp/src/specs/responses.json | Adds response templates (minor capitalization/grammar issue). |
| tools/Mcp/src/services/utils.ts | Core utility functions for swagger/YAML processing, example harvesting (contains logic and path bugs, dead code). |
| tools/Mcp/src/services/toolsService.ts | Implements tool handlers (no critical issues). |
| tools/Mcp/src/services/resourcesService.ts | Implements resource serving (no critical issues flagged). |
| tools/Mcp/src/services/promptsService.ts | Implements prompt handlers (no critical issues). |
| tools/Mcp/src/services/logger.ts | Adds structured logger (log level filtering bug). |
| tools/Mcp/src/CodegenServer.ts | Wires tools/prompts/resources & response loading (OK). |
| tools/Mcp/src/index.ts | Entry point startup script. |
| tools/Mcp/src/assets/* | Adds workflow, example, test, and help templates (one spelling issue). |
| tools/Mcp/package.json | Adds project/package metadata. |
| tools/Mcp/README.md | Documentation for MCP server. |
| src/Maps/Maps.Autorest/test/utils.ps1 | Removes stray trailing blank line. |
Files not reviewed (1)
- tools/Mcp/package-lock.json: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor issue
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.