Skip to content

Conversation

@notyashhh
Copy link
Member

@notyashhh notyashhh commented Oct 15, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 23:48
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Syncs a new Model Context Protocol (MCP) code generation server and related assets into the repository to support Azure PowerShell module scaffolding, code generation, example/test creation, and partner workflow automation.

  • Adds MCP server implementation (TypeScript), tool/prompt/resource specs, response templates, logging, and utilities.
  • Introduces asset templates (examples, tests, help READMEs) and README documentation for the MCP server.
  • Includes build configuration (tsconfig.json, package.json) and minor cleanup in an existing test utility script.

Reviewed Changes

Copilot reviewed 38 out of 41 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
tools/Mcp/tsconfig.json Adds TypeScript compiler configuration for the MCP server (contains invalid module target).
tools/Mcp/src/types.ts Introduces interface type definitions (non‑conventional naming).
tools/Mcp/src/specs/specs.json Defines MCP tool & prompt schemas (minor spelling issue).
tools/Mcp/src/specs/responses.json Adds response templates (minor capitalization/grammar issue).
tools/Mcp/src/services/utils.ts Core utility functions for swagger/YAML processing, example harvesting (contains logic and path bugs, dead code).
tools/Mcp/src/services/toolsService.ts Implements tool handlers (no critical issues).
tools/Mcp/src/services/resourcesService.ts Implements resource serving (no critical issues flagged).
tools/Mcp/src/services/promptsService.ts Implements prompt handlers (no critical issues).
tools/Mcp/src/services/logger.ts Adds structured logger (log level filtering bug).
tools/Mcp/src/CodegenServer.ts Wires tools/prompts/resources & response loading (OK).
tools/Mcp/src/index.ts Entry point startup script.
tools/Mcp/src/assets/* Adds workflow, example, test, and help templates (one spelling issue).
tools/Mcp/package.json Adds project/package metadata.
tools/Mcp/README.md Documentation for MCP server.
src/Maps/Maps.Autorest/test/utils.ps1 Removes stray trailing blank line.
Files not reviewed (1)
  • tools/Mcp/package-lock.json: Language not supported

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor issue

@isra-fel isra-fel merged commit f998c27 into main Oct 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants