[Eng] Fix parameter breaking change in custom ps1 not been processed #28232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
Fixes a breaking change processing issue where parameter breaking changes were not being properly handled in custom PowerShell files. The fix restructures the breaking change message storage logic to ensure proper initialization and handling of both cmdlet and parameter breaking changes.
- Separates hash table initialization from breaking change message addition
- Adds explicit checks for breaking change message type existence before initialization
- Ensures consistent data structure handling for both cmdlet and parameter breaking changes
| } | ||
| If (-not $AllBreakingChangeMessages[$CmdletName][$AllParameterSetsName].ContainsKey("ParameterBreakingChange")) | ||
| { | ||
| $AllBreakingChangeMessages[$CmdletName][$AllParameterSetsName]["ParameterBreakingChange"] = [System.Collections.ArrayList]::New(@($ParameterBreakingChangeMessage)) |
There was a problem hiding this comment.
There's an inconsistency in data types between cmdlet and parameter breaking changes. CmdletBreakingChange uses ArrayList but ParameterBreakingChange was previously assigned directly as a hashtable. The change to ArrayList is correct, but ensure the else block at line 402 is compatible with ArrayList operations.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
NoriZC
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.