Skip to content

[Eng] Fix parameter breaking change in custom ps1 not been processed #28232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

[Eng] Fix parameter breaking change in custom ps1 not been processed #28232

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb88e31
fix get-breakingchangemetadata
VeryEarly Jul 18, 2025
0d38b24
Update tools/BreakingChanges/Get-BreakingChangeMetadata.ps1
VeryEarly Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions tools/BreakingChanges/Get-BreakingChangeMetadata.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,9 +358,11 @@ Function Get-BreakingChangeOfGeneratedModule
}
If (-not $AllBreakingChangeMessages[$CmdletName].ContainsKey($AllParameterSetsName))
{
$AllBreakingChangeMessages[$CmdletName].Add($AllParameterSetsName, @{
"CmdletBreakingChange" = [System.Collections.ArrayList]::New(@($BreakingChangeMessage))
})
$AllBreakingChangeMessages[$CmdletName].Add($AllParameterSetsName, @{})
}
If (-not $AllBreakingChangeMessages[$CmdletName][$AllParameterSetsName].ContainsKey("CmdletBreakingChange"))
{
$AllBreakingChangeMessages[$CmdletName][$AllParameterSetsName]["CmdletBreakingChange"] = [System.Collections.ArrayList]::New(@($BreakingChangeMessage))
}
Else {
$null = $AllBreakingChangeMessages[$CmdletName][$AllParameterSetsName]["CmdletBreakingChange"].Add($BreakingChangeMessage)
Expand Down Expand Up @@ -389,9 +391,11 @@ Function Get-BreakingChangeOfGeneratedModule
}
If (-not $AllBreakingChangeMessages[$CmdletName].ContainsKey($AllParameterSetsName))
{
$AllBreakingChangeMessages[$CmdletName].Add($AllParameterSetsName, @{
"ParameterBreakingChange" = $ParameterBreakingChangeMessage
})
$AllBreakingChangeMessages[$CmdletName].Add($AllParameterSetsName, @{})
}
If (-not $AllBreakingChangeMessages[$CmdletName][$AllParameterSetsName].ContainsKey("ParameterBreakingChange"))
{
$AllBreakingChangeMessages[$CmdletName][$AllParameterSetsName]["ParameterBreakingChange"] = [System.Collections.ArrayList]::New(@($ParameterBreakingChangeMessage))
Copy link

Copilot AI Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an inconsistency in data types between cmdlet and parameter breaking changes. CmdletBreakingChange uses ArrayList but ParameterBreakingChange was previously assigned directly as a hashtable. The change to ArrayList is correct, but ensure the else block at line 402 is compatible with ArrayList operations.

Copilot uses AI. Check for mistakes.
}
Else {
$null = $AllBreakingChangeMessages[$CmdletName][$AllParameterSetsName]["ParameterBreakingChange"].Add($ParameterBreakingChangeMessage)
Expand Down