Skip to content

Conversation

@Jingshu918
Copy link
Contributor

@Jingshu918 Jingshu918 commented Oct 28, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings October 28, 2025 05:21
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Data Factory PowerShell module to add support for additional HDInsightOnDemand connection properties by updating the AutoRest generation to use a newer commit of the Azure REST API specifications.

Key Changes

  • Updated AutoRest generation to use a newer API specification commit
  • Added changelog entry for HDInsightOnDemand connection properties support

Reviewed Changes

Copilot reviewed 2 out of 27 changed files in this pull request and generated 2 comments.

File Description
src/DataFactory/DataFactory/ChangeLog.md Added changelog entry documenting new HDInsightOnDemand connection properties support
src/DataFactory/DataFactory.Management.Sdk/README.md Updated AutoRest commit hash and specification path to generate SDK from newer API specs

- Additional information about change #1
-->
## Upcoming Release
* Added more support for HDInsightOnDemand connection properties.
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry lacks user-focused context and GitHub issue reference. It should explain what specific connection properties were added and how this impacts users. Additionally, include a reference to the related GitHub issue using the format [#12345]. Example: 'Added support for additional connection properties in HDInsightOnDemand linked services, including X, Y, and Z properties [#12345]'.

Copilot generated this review using guidance from repository custom instructions.
commit: aabf307e72445d56c94f896bf2e9bd226fbdf3d6
require: https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/datafactory/resource-manager/readme.md
commit: c6e5248223e3bac9293ea4e0ac7c56f16c334e6a
require: https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/datafactory/resource-manager/Microsoft.DataFactory/DataFactory/readme.md
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specification path has changed from 'specification/datafactory/resource-manager/readme.md' to 'specification/datafactory/resource-manager/Microsoft.DataFactory/DataFactory/readme.md'. This appears to be an intentional path update, but verify that this new path exists in commit c6e5248223e3bac9293ea4e0ac7c56f16c334e6a to prevent AutoRest generation failures.

Suggested change
require: https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/datafactory/resource-manager/Microsoft.DataFactory/DataFactory/readme.md
require: https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/datafactory/resource-manager/readme.md

Copilot uses AI. Check for mistakes.
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dolauli dolauli merged commit 3b43f89 into Azure:main Oct 29, 2025
12 checks passed
@dolauli dolauli self-assigned this Oct 30, 2025
@dolauli dolauli added this to the Az 15.0.0 (11/18/2025) milestone Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants