-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Add ResiliencyView parameter to Get-AzVmssVM for monitoring Resilient Delete retries #28927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ResiliencyView parameter to Get-AzVmssVM for monitoring Resilient Delete retries #28927
Conversation
Updated agent configuration to specify a PowerShell Pull Request Agent with detailed objectives and rules for modifying cmdlets.
Co-authored-by: audreyttt <225061541+audreyttt@users.noreply.github.com>
Co-authored-by: audreyttt <225061541+audreyttt@users.noreply.github.com>
Co-authored-by: audreyttt <225061541+audreyttt@users.noreply.github.com>
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new -ResiliencyView parameter to the Get-AzVmssVM cmdlet to enable monitoring of the Resilient Delete feature for Virtual Machine Scale Set (VMSS) VMs. The parameter retrieves the ResilientVMDeletionStatus property, which indicates whether automatic delete retries are in progress, failed, or not started. This implementation aligns with the design proposal referenced in issue #1527.
Key changes:
- Added
-ResiliencyViewswitch parameter to retrieve resilient VM deletion status - Updated help documentation with new parameter description and usage example
- Added test coverage for the new functionality
- Fixed a spelling error in help documentation ("Species" → "Specifies")
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Compute/Compute/Generated/VirtualMachineScaleSetVM/VirtualMachineScaleSetVMGetMethod.cs | Implements the ResiliencyView parameter, adds conditional logic to retrieve status using ResiliencyViewExpand enum value |
| src/Compute/Compute/Generated/Models/PSVirtualMachineScaleSetVM.cs | Adds ResilientVMDeletionStatus string property to the model for storing the deletion status |
| src/Compute/Compute/help/Get-AzVmssVM.md | Documents the new parameter with description and example, also fixes spelling error |
| src/Compute/Compute/ChangeLog.md | Adds changelog entry describing the new feature for users |
| src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1 | Adds PowerShell test function to verify ResiliencyView parameter works correctly |
| src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.cs | Adds C# test method to execute the PowerShell test |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
src/Compute/Compute/Generated/VirtualMachineScaleSetVM/VirtualMachineScaleSetVMGetMethod.cs
Show resolved
Hide resolved
src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description
Adding new parameter as requested by this design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1527
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.