Skip to content

Conversation

@JunKai-v
Copy link

Description

Migration PR: #29023

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings January 30, 2026 04:23
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@JunKai-v JunKai-v marked this pull request as draft January 30, 2026 04:24
@JunKai-v JunKai-v added Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 labels Jan 30, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds breaking change announcement warnings to DataProtection module cmdlets in preparation for an AutoRest v4 migration (referenced in PR #29023). The changes include adding PreviewMessage attributes to cmdlets, updating help documentation, incrementing the module version to 2.8.0, and regenerating AutoRest configuration files.

Changes:

  • Added breaking change warning messages to 18 DataProtection cmdlets via PreviewMessage attributes
  • Updated module version from 2.7.0 to 2.8.0 and Az.Accounts dependency from 5.3.0 to 5.3.1
  • Corrected spelling errors in help documentation markdown files

Reviewed changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 39 comments.

Show a summary per file
File Description
src/DataProtection/DataProtection/help/*.md (11 files) Spelling corrections in cmdlet help documentation
src/DataProtection/DataProtection/Az.DataProtection.psd1 Updated module version to 2.8.0, Az.Accounts dependency to 5.3.1, and uncommented ScriptsToProcess/TypesToProcess
src/DataProtection/DataProtection.sln Regenerated solution file with updated project GUID
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/**/*.ps1 (18 files) Added PreviewMessage attributes announcing breaking changes
src/DataProtection/DataProtection.Autorest/README.md Added AutoRest directive to configure breaking change preview messages
src/DataProtection/DataProtection.Autorest/Properties/AssemblyInfo.cs Updated assembly version to 2.8.0
src/DataProtection/DataProtection.Autorest/generate-info.json Updated generation ID
src/DataProtection/DataProtection.Autorest/docs/Az.DataProtection.md Updated module GUID
src/DataProtection/DataProtection.Autorest/.gitignore Removed ignore entries for custom/*.psm1 and custom/autogen-model-cmdlets

This command adds a weekly tag to given backup policy

### Example 2: Remove Weekly tag from Backup Policy
### Example 2: Remove Weeky tag from Backup Policy
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "Weeky" should be "Weekly".

Suggested change
### Example 2: Remove Weeky tag from Backup Policy
### Example 2: Remove Weekly tag from Backup Policy

Copilot uses AI. Check for mistakes.
Comment on lines +6 to +8
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PreviewMessage attribute contains incorrect information. The message states the breaking change will occur in "Az v16.0.0, to be released on May 2026", but the README.md directive (line 489) indicates it should be "Az v15.0.0, to be released on November 19th 2025". There is a version number mismatch and date mismatch between the cmdlet attribute and the AutoRest configuration.

Suggested change
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n
* This cmdlet will undergo a breaking change in Az v15.0.0, to be released on November 19th 2025. *`n
* At least one change applies to this cmdlet. *`n
* See all possible breaking changes at https://go.microsoft.com/fwlink/?linkid=2333486 *`n

Copilot uses AI. Check for mistakes.
[CmdletBinding(PositionalBinding=$false)]
[Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Description('Gets or lists jobs in a backup vault')]
[Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Runtime.PreviewMessage("**********************************************************************************************`n
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PreviewMessage attribute contains incorrect information. The message states the breaking change will occur in "Az v16.0.0, to be released on May 2026", but the README.md directive (line 489) indicates it should be "Az v15.0.0, to be released on November 19th 2025". There is a version number mismatch and date mismatch between the cmdlet attribute and the AutoRest configuration.

Suggested change
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
* This cmdlet will undergo a breaking change in Az v15.0.0, to be released on November 19th 2025. *`n

Copilot uses AI. Check for mistakes.

This command is used to change CmkIdentityType from SystemAssigned to UserAssigned.
CmkIdentityId is a required parameter.
This command is used to change CmkIdentityType from SystemAssigned to UserAssgined.
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "UserAssgined" should be "UserAssigned".

Copilot uses AI. Check for mistakes.

The first, second commands fetch the instance and recovery point for the instance.
The third and fourth command initializes the target container id and target storage account ARM id.
The third and fourthcommand initializes the target container id and target storage account ARM id.
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing error: "fourthcommand" should be "fourth command" (missing space).

Copilot uses AI. Check for mistakes.
Comment on lines 5 to 10
internal
exports
tools
custom/*.psm1
custom/autogen-model-cmdlets
test/*-TestResults.xml
license.txt
/*.ps1
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of these two gitignore entries may have unintended consequences. The entries "custom/*.psm1" and "custom/autogen-model-cmdlets" were previously ignored but are now tracked. If these paths should remain untracked (e.g., because they contain generated or temporary files), this change should be reverted. Please verify whether these paths should be tracked in version control.

Copilot uses AI. Check for mistakes.
Fetch the backup instance.
Fetch valid time ranges for Backup Instance $instance[0].
Display RestorableTimeRange, note that this can be multiple discrete ranges.
Dispaly RestorableTimeRange, note that this can be multiple dicrete ranges.
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "dicrete" should be "discrete".

Suggested change
Dispaly RestorableTimeRange, note that this can be multiple dicrete ranges.
Display RestorableTimeRange, note that this can be multiple discrete ranges.

Copilot uses AI. Check for mistakes.
[CmdletBinding(PositionalBinding=$false)]
[Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Description('Gets default policy template for a selected datasource type.')]
[Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Runtime.PreviewMessage("**********************************************************************************************`n
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PreviewMessage attribute contains incorrect information. The message states the breaking change will occur in "Az v16.0.0, to be released on May 2026", but the README.md directive (line 489) indicates it should be "Az v15.0.0, to be released on November 19th 2025". There is a version number mismatch and date mismatch between the cmdlet attribute and the AutoRest configuration.

Suggested change
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
* This cmdlet will undergo a breaking change in Az v15.0.0, to be released on November 19th 2025. *`n

Copilot uses AI. Check for mistakes.
[CmdletBinding(PositionalBinding=$false, SupportsShouldProcess)]
[Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Description('Creates or updates a BackupVault resource belonging to a resource group.')]
[Microsoft.Azure.PowerShell.Cmdlets.DataProtection.Runtime.PreviewMessage("**********************************************************************************************`n
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PreviewMessage attribute contains incorrect information. The message states the breaking change will occur in "Az v16.0.0, to be released on May 2026", but the README.md directive (line 489) indicates it should be "Az v15.0.0, to be released on November 19th 2025". There is a version number mismatch and date mismatch between the cmdlet attribute and the AutoRest configuration.

Suggested change
* This cmdlet will undergo a breaking change in Az v16.0.0, to be released on May 2026. *`n
* This cmdlet will undergo a breaking change in Az v15.0.0, to be released on November 19th 2025. *`n

Copilot uses AI. Check for mistakes.
```

The first command is used to fetch the backup instances which are in soft deleted for a give backup vault.
The first comamnd is used to fetch the backup instances which are in soft deleted for a give backup vault.
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "comamnd" should be "command".

Copilot uses AI. Check for mistakes.
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@JunKai-v
Copy link
Author

JunKai-v commented Feb 3, 2026

replaced by #29125

@JunKai-v JunKai-v deleted the dataprotection-BC branch February 3, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants