Onboard KubernetesConfiguration to Private Link Common cmdlets#29319
Onboard KubernetesConfiguration to Private Link Common cmdlets#29319NoriZC merged 3 commits intoAzure:mainfrom
Conversation
…vate Link Common Cmdlets
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull request overview
This PR onboards the Microsoft.KubernetesConfiguration/privateLinkScopes resource type into Az.Network’s Private Link “common cmdlets” by extending the Network module’s private link provider configuration and documenting the change in the module changelog.
Changes:
- Added a new
RegisterConfigurationentry forMicrosoft.KubernetesConfiguration/privateLinkScopesin the Private Link provider configuration list. - Added an “Upcoming Release” changelog entry noting the onboarding to Private Link common cmdlets.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Network/Network/PrivateLinkService/PrivateLinkServiceProvider/ProviderConfiguration.cs |
Registers KubernetesConfiguration privateLinkScopes so Private Link common cmdlets can route requests using an RP-specific API version and capability flags. |
src/Network/Network/ChangeLog.md |
Notes the new onboarding under “Upcoming Release” for Az.Network users. |
| RegisterConfiguration("Microsoft.HealthDataAIServices/deidServices", "2024-09-20", true, false); | ||
| RegisterConfiguration("Microsoft.HDInsight/clusters", "2018-06-01-preview", true, true); | ||
| RegisterConfiguration("Microsoft.HybridCompute/privateLinkScopes", "2021-05-20", true, true); | ||
| RegisterConfiguration("Microsoft.KubernetesConfiguration/privateLinkScopes", "2024-11-01-preview", true, true); |
There was a problem hiding this comment.
The API version 2024-11-01-preview for Microsoft.KubernetesConfiguration/privateLinkScopes looks inconsistent with the KubernetesConfiguration RP versions used elsewhere in this repo (for example, the KubernetesConfiguration module targets 2022-11-01). Since this ApiVersion is used directly in GenericProvider REST calls, an incorrect value will cause the Private Link common cmdlets to fail for this resource type. Please verify the correct ARM api-version that supports privateLinkScopes for Microsoft.KubernetesConfiguration and update this registration accordingly (and consider adding a regression test or recording if available).
| RegisterConfiguration("Microsoft.KubernetesConfiguration/privateLinkScopes", "2024-11-01-preview", true, true); | |
| RegisterConfiguration("Microsoft.KubernetesConfiguration/privateLinkScopes", "2022-11-01", true, true); |
src/Network/Network/ChangeLog.md
Outdated
| * Onboarded `Microsoft.KubernetesConfiguration/privateLinkScopes` to Private Link Common Cmdlets | ||
|
|
There was a problem hiding this comment.
This changelog entry is quite internal ("Onboarded … to Private Link Common Cmdlets") and doesn’t clearly tell users what they can do differently. Consider rephrasing from the user perspective (for example, that the Private Link common cmdlets now support managing private endpoint connections/private link resources for Microsoft.KubernetesConfiguration/privateLinkScopes), and add a short sub-bullet if needed to clarify the impact.
| * Onboarded `Microsoft.KubernetesConfiguration/privateLinkScopes` to Private Link Common Cmdlets | |
| * Added support in Azure Private Link common cmdlets for managing `Microsoft.KubernetesConfiguration/privateLinkScopes` resources | |
| - You can now manage private endpoint connections and private link resources for Azure Kubernetes Configuration private link scopes using the common Private Link cmdlets |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Onboard KubernetesConfiguration to Private Link Common cmdlets
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.