Skip to content

[StackHCI] Add DoNotExportAttribute to internal functions#29329

Merged
VeryEarly merged 1 commit intoAzure:mainfrom
JiaSeng-v:jiaseng/main/StackHCI
Mar 27, 2026
Merged

[StackHCI] Add DoNotExportAttribute to internal functions#29329
VeryEarly merged 1 commit intoAzure:mainfrom
JiaSeng-v:jiaseng/main/StackHCI

Conversation

@JiaSeng-v
Copy link
Copy Markdown
Contributor

@JiaSeng-v JiaSeng-v commented Mar 27, 2026

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@JiaSeng-v JiaSeng-v requested review from VeryEarly and Copilot March 27, 2026 09:00
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@JiaSeng-v JiaSeng-v force-pushed the jiaseng/main/StackHCI branch from 1f79339 to 43ec7fc Compare March 27, 2026 09:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the StackHCI module’s exported surface by marking additional helper functions as non-exportable, along with regenerated module artifacts/help content.

Changes:

  • Add DoNotExportAttribute to additional internal helper functions in the StackHCI custom script to prevent unintended exports.
  • Regenerate/update Register-AzStackHCI markdown help to include the -useStableAgentVersion switch.
  • Update various generated metadata/artifacts (module manifest formatting/dependencies, solution/project GUID, generate-info id, assembly version).

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/StackHCI/StackHCI/help/Register-AzStackHCI.md Adds documentation for -useStableAgentVersion in shipped help.
src/StackHCI/StackHCI/Az.StackHCI.psd1 Regenerated manifest metadata (date/dependency) and minor formatting/field presence changes.
src/StackHCI/StackHCI.sln Updates the Az.StackHCI project GUID and associated solution mappings.
src/StackHCI/StackHCI.Autorest/generate-info.json Updates generation identifier.
src/StackHCI/StackHCI.Autorest/docs/Register-AzStackHCI.md Adds documentation for -useStableAgentVersion in AutoRest docs.
src/StackHCI/StackHCI.Autorest/docs/Az.StackHCI.md Updates docs front-matter module GUID.
src/StackHCI/StackHCI.Autorest/custom/stackhci.ps1 Marks additional helper functions with DoNotExportAttribute.
src/StackHCI/StackHCI.Autorest/Properties/AssemblyInfo.cs Updates assembly version to match module version.

@VeryEarly VeryEarly enabled auto-merge (squash) March 27, 2026 09:09
@VeryEarly VeryEarly changed the title Add DoNotExportAttribute to StackHCI [StackHCI] Add DoNotExportAttribute to internal functions Mar 27, 2026
@VeryEarly VeryEarly changed the title [StackHCI] Add DoNotExportAttribute to internal functions [StackHCI] Add DoNotExportAttribute to internal functions Mar 27, 2026
@VeryEarly VeryEarly merged commit a0e3740 into Azure:main Mar 27, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants