Skip to content

Progress Bar update #5487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2018
Merged

Progress Bar update #5487

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94364a1
progress bar frequency.
sergey-shandar Feb 9, 2018
911d5f0
Merge branch 'release-2018-02-09' into sergey-progress-bar
sergey-shandar Feb 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions src/ResourceManager/Compute/Commands.Compute/Strategies/AsyncCmdletExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
using System;
using System.Collections.Generic;
using System.Management.Automation;
using System.Threading;
using System.Threading.Tasks;

namespace Microsoft.Azure.Commands.Compute.Strategies
Expand All @@ -32,6 +31,8 @@ public static void StartAndWait(
this Cmdlet cmdlet, Func<IAsyncCmdlet, Task> createAndStartTask)
{
var asyncCmdlet = new AsyncCmdlet(cmdlet);
string previousX = null;
string previousOperation = null;
asyncCmdlet.Scheduler.Wait(
createAndStartTask(asyncCmdlet),
() =>
Expand All @@ -52,17 +53,25 @@ public static void StartAndWait(
var percent = (int)(progress * 100.0);
var r = new[] { "|", "/", "-", "\\" };
var x = r[DateTime.Now.Second % 4];
cmdlet.WriteProgress(
new ProgressRecord(
0,
"Creating Azure resources",
percent + "% " + x)
{
CurrentOperation = activeTasks.Count > 0
? "Creating " + string.Join(", ", activeTasks) + "."
: null,
PercentComplete = percent,
});
var operation = activeTasks.Count > 0
? "Creating " + string.Join(", ", activeTasks) + "."
: null;

// write progress only if it's changed.
if (x != previousX || operation != previousOperation)
{
cmdlet.WriteProgress(
new ProgressRecord(
0,
"Creating Azure resources",
percent + "% " + x)
{
CurrentOperation = operation,
PercentComplete = percent,
});
previousX = x;
previousOperation = operation;
}
}
});
}
Expand Down