Skip to content

Conversation

@maddieclayton
Copy link
Contributor

@maddieclayton maddieclayton commented Mar 7, 2018

Description

Fix issue where accountname cannot be uppercase.

Checklist

blueww
blueww previously approved these changes Mar 8, 2018
Copy link
Member

@blueww blueww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to also change the help of other cmdlets get/Set/New/Update-AzureRmStorageAccount, to make they are aligned. But consider other cmdlets will use an exist account name (which should already be lower case), and this cmdlet will input a new account name, fix this cmdlet help will be more important.

@maddieclayton
Copy link
Contributor Author

@blueww Thanks for pointing that out - I have updated all the help files in storage to use lower case syntax in StorageAccountName.

cormacpayne
cormacpayne previously approved these changes Mar 8, 2018
@blueww
Copy link
Member

blueww commented Mar 9, 2018

The storage cmdlets help change looks good to me. Someone else might need to review the test change.

@maddieclayton maddieclayton merged commit d1c91a5 into preview Mar 9, 2018
@maddieclayton maddieclayton deleted the maddieclayton-patch-3 branch March 9, 2018 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants