New-AzureRmVM/VMSS: DataDiskSizeInGb parameter #5734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-shandar
changed the title
markcowl
requested changes
Mar 14, 2018
| FrontendPoolName = FrontendPoolName ?? VMScaleSetName; | ||
| BackendPoolName = BackendPoolName ?? VMScaleSetName; | ||
| [Parameter(ParameterSetName = SimpleParameterSet, Mandatory = false)] | ||
| public int[] DataDiskSizeGb { get; set; } |
Member
There was a problem hiding this comment.
Is there a good ValidateRange for this? a minimum and a maximum?
Contributor
Author
There was a problem hiding this comment.
I'm not aware of validation rules. I assume, it can't be negative. How to define validation rules for arrays?
|
|
||
| namespace Microsoft.Azure.Commands.Compute.Strategies.ComputeRp | ||
| { | ||
| static class DataDiskStrategy |
markcowl
requested changes
Mar 14, 2018
| ManagedDisk = engine.GetReference(disk, StorageAccountTypes.PremiumLRS), | ||
| } | ||
| }, | ||
| DataDisks = DataDiskStrategy.CreateDataDisks(0, dataDisks) |
Member
There was a problem hiding this comment.
Why is the data disk count always 0?
Contributor
Author
There was a problem hiding this comment.
This configuration for VHD OS disks only. I have no idea how to extract this information from VHD. I'm not sure if it's possible.
sergey-shandar
changed the title
sergey-shandar
changed the title
sergey-shandar
changed the title
markcowl
previously approved these changes
Mar 20, 2018
Member
cormacpayne
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New-AzureRmVMSS: DataDiskSizeInGb parameter.
Issue #5661
Depends on #5721
Checklist
CONTRIBUTING.mdplatyPSmodule