-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Storage] Add StaticWebSite Dataplane Support #6518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@praries880 I will definitely update it after XSCL is released. |
|
@blueww can you fix the build breaks in both the Jenkin and net core builds |
|
@praries880 Would you please help to review before XSCL release, and see it any change need for this feature? |
|
@blueww will review the code, will mark it as do not merge though :) |
praries880
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor comments.. otherwise looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming this will be undone once the new SDK is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will update all the reference when the XSCL is release. Currently remove the “PublicKeyToken” only to make the private XSCL work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these about? to set them in the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This parameter will show the user the StaticWebsite setting after the change. So they can have a check.
This is aligned with other serverproperty cmdlets like
enable/disable-AzureStorageDeleteRetentionPolicy
Set-AzureStorageServiceLoggingProperty
Set-AzureStorageServiceMetricsProperty
Set-AzureStorageServiceProperty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says "Overwrite the useless parameter".. these dont seem useless :)
|
I have updated the PR to the released XSCL and private signed DMlib. I have also updated the change log and module version. (not sure if 4.4.1 is correct version) |
praries880
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor nitpicks.. otherwise looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment says "Overwrite the useless parameter".. these dont seem useless :)
| [Parameter(Mandatory = false)] | ||
| public SwitchParameter PassThru { get; set; } | ||
|
|
||
| // Overwrite the useless parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these really useless?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, these are useless. These parameter are for the long running blob/file content transfer cmdlets. But for this cmdlet, it's just a property setting, and can finish very quickly, don't need set special timeout and concurrent.
Description
This PR is to add the static Web data plane support.
It already pass review in https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/88
Since the XSCL still not released, this based on private XSCL and DMlib (So build won't pass). It's just for a early code review to reduce the risk for the late code review.
I will update it when XSCL released.
Checklist
CONTRIBUTING.mdplatyPSmodule