changing principalid and objectid from GUID to string for ADFS scenarios

[bganapa]

Description

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate change log has been updated
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • the changes have gone through a cmdlet design review
  • the cmdlet markdown files were generated using the platyPS module

[markcowl]

Public API surface cannot be changed in this way - you could add a new method, but not change the signature of an existing one

[bganapa]

sure.. I will do that.. thought abt doing it, wanted to get your opinion before doing the extra work :)

[markcowl]

Same - this is a disallowed breaking change

[markcowl]

Same. We could add a new property which was a string, but we cannot change the siagnature of an existing property

[markcowl]

Additionally, once this is fixed, can we add a recorded test from AzureStack, to prevent regressions in the future.

[maddieclayton]

@bganapa You will need to move the changes to src/Common here: https://github.com/Azure/azure-powershell-common. Once you create a PR there, run this job with your fork and branch: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-common-sign/. Take the relevant packages, copy them into local feed, and from there you can test the common changes. Let me know if you have any questions about this process.

[bganapa]

closing this PR infavor of Azure/azure-powershell-common#30